hgreview.py - Issue 29349225: Issue 4313 - hg review shouldn't fail if the repository has no URL configured

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: hgreview.py

Issue 29349225: Issue 4313 - hg review shouldn't fail if the repository has no URL configured (Closed)

Patch Set: Structure the code a bit better Created Aug. 16, 2016, 10:36 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: hgreview.py

===================================================================

--- a/hgreview.py

+++ b/hgreview.py

@@ -60,17 +60,19 @@ def review(ui, repo, *paths, **opts):

if not opts.get('title'):

opts['title'] = ui.prompt('New review title: ', '')

if not opts['title'].strip():

raise error.Abort('No review title given.')

if not opts.get('message'):

opts['message'] = opts['title']

- path = ui.config('paths', 'default-push') or ui.config('paths', 'default')

+ path = (ui.config('paths', 'default-push')

+ or ui.config('paths', 'default')

+ or '')

match = re.search(r'^(?:https://|ssh://hg@)(.*)', path)

if match:

opts['message'] = '{0}\n\nRepository: {1}'.format(

opts['message'].strip(),

match.group(1)

)

# Make sure there is at least one reviewer

« no previous file with comments | « no previous file | no next file » | no next file with comments »