Unified Diff: lib/icon.js
Issue 29349240:
Issue 4218 - Browser icons for newer Chrome + Edge (Closed)
Patch Set: Avoid JSHydra generating inefficient code
Created Aug. 9, 2016, 1:54 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« chrome/icons/abp-40-whitelisted.png ('k')
|
metadata.chrome » ('j')
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: lib/icon.js |
| diff --git a/lib/icon.js b/lib/icon.js |
| index 04f3f0ac1c37dfd7e8176bdc00ada99febafad0c..22f80bc2290d7ece7921ddcaa1bc656fed22d7ab 100644 |
| --- a/lib/icon.js |
| +++ b/lib/icon.js |
| @@ -85,17 +85,33 @@ function renderFrames(notificationType) |
| return Promise.resolve(null); |
| return Promise.all([ |
| + loadImage("icons/abp-16.png"), |
| + loadImage("icons/abp-16-whitelisted.png"), |
| + loadImage("icons/abp-16-notification-" + notificationType + ".png"), |
| loadImage("icons/abp-19.png"), |
| loadImage("icons/abp-19-whitelisted.png"), |
| loadImage("icons/abp-19-notification-" + notificationType + ".png"), |
| + loadImage("icons/abp-20.png"), |
| + loadImage("icons/abp-20-whitelisted.png"), |
| + loadImage("icons/abp-20-notification-" + notificationType + ".png"), |
| + loadImage("icons/abp-32.png"), |
| + loadImage("icons/abp-32-whitelisted.png"), |
| + loadImage("icons/abp-32-notification-" + notificationType + ".png"), |
| loadImage("icons/abp-38.png"), |
| loadImage("icons/abp-38-whitelisted.png"), |
| loadImage("icons/abp-38-notification-" + notificationType + ".png"), |
| + loadImage("icons/abp-40.png"), |
| + loadImage("icons/abp-40-whitelisted.png"), |
| + loadImage("icons/abp-40-notification-" + notificationType + ".png") |
| ]).then(images => |
| { |
| let images = { |
| - 19: { base: [images[0], images[1]], overlay: images[2] }, |
| - 38: { base: [images[3], images[4]], overlay: images[5] } |
| + 16: { base: [images[0], images[1]], overlay: images[2] }, |
| + 19: { base: [images[3], images[4]], overlay: images[5] }, |
| + 20: { base: [images[6], images[7]], overlay: images[8] }, |
| + 32: { base: [images[9], images[10]], overlay: images[11] }, |
| + 38: { base: [images[12], images[13]], overlay: images[14] }, |
| + 40: { base: [images[15], images[16]], overlay: images[17] } |
| }; |
| let frames = {}; |
| @@ -107,7 +123,8 @@ function renderFrames(notificationType) |
| for (let i = 0, opacity = 0; i <= 10; opacity = ++i / 10) |
| { |
| let imageData = {}; |
| - for (let size of [19, 38]) |
| + let sizes = [16, 19, 20, 32, 38, 40]; |
| + for (let size of sizes) |
| { |
| canvas.width = size; |
| canvas.height = size; |
« no previous file with comments
|
« chrome/icons/abp-40-whitelisted.png ('k')
|
metadata.chrome » ('j')
|
no next file with comments »
