Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29349784: Issue 4282 - Fix Google exception rules to include www subdomain (Closed)

Created:
Aug. 12, 2016, 11 a.m. by kzar
Modified:
Aug. 12, 2016, 12:05 p.m.
Reviewers:
Sebastian Noack
Visibility:
Public.

Description

Issue 4282 - Fix Google exception rules to include www subdomain

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1319 lines, -1319 lines) Patch
M easylist+exceptionrules_content_blocker.json View 1319 chunks +1319 lines, -1319 lines 0 comments Download

Messages

Total messages: 4
kzar
Patch Set 1 Sorry for the huge review. FWIW I tested this didn't break content ...
Aug. 12, 2016, 11:04 a.m. (2016-08-12 11:04:26 UTC) #1
kzar
(Also fixed #4283, #4286 and at least the search ads for quoka.de in #3723.)
Aug. 12, 2016, 11:12 a.m. (2016-08-12 11:12:27 UTC) #2
Sebastian Noack
LGTM However, this is certainly something abp2blocklist could and should take care of in the ...
Aug. 12, 2016, 11:42 a.m. (2016-08-12 11:42:31 UTC) #3
kzar
Aug. 12, 2016, 11:57 a.m. (2016-08-12 11:57:59 UTC) #4
I agree. I'll double check abp2blocklist doesn't already do this, and if not
I'll open an issue.

Powered by Google App Engine
This is Rietveld