Fixes 4218 - setIcon for older, fussy versions of Chrome

chrome/ext/background.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 152 matching lines @@
   chrome.tabs.onRemoved.addListener(forgetTab);
 
   chrome.tabs.onActivated.addListener(function(details)
   {
     ext.pages.onActivated._dispatch(new Page({id: details.tabId}));
   });
 
 
   /* Browser actions */
 
+  var supportedIconSizes = ["19", "38", "16", "32", "20", "40"];
+
   var BrowserAction = function(tabId)
   {
     this._tabId = tabId;
     this._changes = null;
   };
   BrowserAction.prototype = {
+    _safeChromeSetIcon: function(details)
+    {
+      try
+      {
+        chrome.browserAction.setIcon(details);
+      }
+      catch (e)
+      {
+        // Edge and newer versions of Chrome prefer different icon sizes, but
+        // older versions of Chrome cannot handle them being present!
+        supportedIconSizes.splice(2);
+
+        for (var key of ["path", "imageData"])
+        {
+          if (!(key in details))
+            continue;
+
+          for (var size in details[key])
+          {
+            if (details[key].hasOwnProperty(size) &&
+                supportedIconSizes.indexOf(size) == -1)
+              delete details[key][size];
+          }
+        }
+        chrome.browserAction.setIcon(details);
+      }
+    },
     _applyChanges: function()
     {
       if ("iconPath" in this._changes)
       {
-        chrome.browserAction.setIcon({
-          tabId: this._tabId,
-          path: {
-            16: this._changes.iconPath.replace("$size", "16"),
-            19: this._changes.iconPath.replace("$size", "19"),
-            20: this._changes.iconPath.replace("$size", "20"),
-            32: this._changes.iconPath.replace("$size", "32"),
-            38: this._changes.iconPath.replace("$size", "38"),
-            40: this._changes.iconPath.replace("$size", "40")
-          }
-        });
+        var details = {tabId: this._tabId, path: {}};
+        for (var size of supportedIconSizes)
+          details.path[size] = this._changes.iconPath.replace("$size", size);
+        this._safeChromeSetIcon(details);
       }
 
       if ("badgeText" in this._changes)
       {
         chrome.browserAction.setBadgeText({
           tabId: this._tabId,
           text: this._changes.badgeText
         });
       }
 
@@ skipping 391 matching lines @@
   ext.windows = {
     create: function(createData, callback)
     {
       chrome.windows.create(createData, function(createdWindow)
       {
         afterTabLoaded(callback)(createdWindow.tabs[0]);
       });
     }
   };
 })();