Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: lib/icon.js

Issue 29349820: Fixes 4218 - setIcon for older, fussy versions of Chrome (Closed)
Patch Set: Go with Sebastian's approach Created Aug. 16, 2016, 12:38 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/ext/background.js ('K') | « chrome/ext/background.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/icon.js
diff --git a/lib/icon.js b/lib/icon.js
index 22f80bc2290d7ece7921ddcaa1bc656fed22d7ab..350389d672eb81b50da627173003b5a8e8d133ad 100644
--- a/lib/icon.js
+++ b/lib/icon.js
@@ -65,7 +65,7 @@ function setIcon(page, notificationType, opacity, frames)
}
else
{
- chrome.browserAction.setIcon({
+ page.browserAction._safeSetIcon({
tabId: page.id,
imageData: frames["" + opacity + whitelisted]
});
« chrome/ext/background.js ('K') | « chrome/ext/background.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld