Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29349823: Fixes 4328 - Multiple shadowRoot deprecated warnings (Closed)

Created:
Aug. 15, 2016, 8:27 p.m. by kzar
Modified:
Nov. 17, 2016, 3:59 p.m.
Reviewers:
Sebastian Noack
Visibility:
Public.

Description

Fixes 4328 - Multiple shadowRoot deprecated warnings

Patch Set 1 #

Patch Set 2 : Reuse existing shadowRoot #

Total comments: 2

Patch Set 3 : Fixed indentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M include.preload.js View 1 2 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 10
kzar
Patch Set 1
Aug. 15, 2016, 8:28 p.m. (2016-08-15 20:28:35 UTC) #1
Sebastian Noack
That doesn't work. We create our shadow root first hence it is always null at ...
Aug. 15, 2016, 8:44 p.m. (2016-08-15 20:44:43 UTC) #2
kzar
On 2016/08/15 20:44:43, Sebastian Noack wrote: > That doesn't work. We create our shadow root ...
Aug. 15, 2016, 8:45 p.m. (2016-08-15 20:45:58 UTC) #3
Sebastian Noack
On 2016/08/15 20:45:58, kzar wrote: > On 2016/08/15 20:44:43, Sebastian Noack wrote: > > That ...
Aug. 16, 2016, 8:24 a.m. (2016-08-16 08:24:29 UTC) #4
kzar
On 2016/08/16 08:24:29, Sebastian Noack wrote: > On 2016/08/15 20:45:58, kzar wrote: > > On ...
Aug. 16, 2016, 8:35 a.m. (2016-08-16 08:35:35 UTC) #5
Sebastian Noack
On 2016/08/16 08:35:35, kzar wrote: > On 2016/08/16 08:24:29, Sebastian Noack wrote: > > On ...
Aug. 16, 2016, 9:22 a.m. (2016-08-16 09:22:34 UTC) #6
kzar
Patch Set 2: Reuse existing shadowRoot Yea, good point. I'll do it that way, so ...
Aug. 22, 2016, 12:36 p.m. (2016-08-22 12:36:44 UTC) #7
Sebastian Noack
https://codereview.adblockplus.org/29349823/diff/29350051/include.preload.js File include.preload.js (right): https://codereview.adblockplus.org/29349823/diff/29350051/include.preload.js#newcode470 include.preload.js:470: document.documentElement.createShadowRoot(); Nit: It seems the indentation is off by ...
Nov. 17, 2016, 3:38 p.m. (2016-11-17 15:38:00 UTC) #8
kzar
Patch Set 3 : Fixed indentation https://codereview.adblockplus.org/29349823/diff/29350051/include.preload.js File include.preload.js (right): https://codereview.adblockplus.org/29349823/diff/29350051/include.preload.js#newcode470 include.preload.js:470: document.documentElement.createShadowRoot(); On 2016/11/17 ...
Nov. 17, 2016, 3:45 p.m. (2016-11-17 15:45:54 UTC) #9
Sebastian Noack
Nov. 17, 2016, 3:46 p.m. (2016-11-17 15:46:35 UTC) #10
LGTM

Powered by Google App Engine
This is Rietveld