packagerSafari.py - Issue 29349885: Issue 4340 - Drop dependency on external xar tool

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: packagerSafari.py

Issue 29349885: Issue 4340 - Drop dependency on external xar tool (Closed)

Left Patch Set: Merged cert and private key extraction Created Aug. 17, 2016, 2:10 p.m.

Right Patch Set: Addressed more nits Created Aug. 17, 2016, 7:21 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 # This Source Code Form is subject to the terms of the Mozilla Public	1 # This Source Code Form is subject to the terms of the Mozilla Public

2 # License, v. 2.0. If a copy of the MPL was not distributed with this	2 # License, v. 2.0. If a copy of the MPL was not distributed with this

3 # file, You can obtain one at http://mozilla.org/MPL/2.0/.	3 # file, You can obtain one at http://mozilla.org/MPL/2.0/.

4	4

5 import base64	5 import base64

6 import ConfigParser	6 import ConfigParser

7 import json	7 import json

8 import os	8 import os

9 import re	9 import re

10 from urlparse import urlparse	10 from urlparse import urlparse

(...skipping 173 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
184	184

185 dirname = metadata.get('general', 'basename') + '.safariextension'	185 dirname = metadata.get('general', 'basename') + '.safariextension'

186 for filename in files.keys():	186 for filename in files.keys():

187 files[os.path.join(dirname, filename)] = files.pop(filename)	187 files[os.path.join(dirname, filename)] = files.pop(filename)

188	188

189 if not devenv and keyFile:	189 if not devenv and keyFile:

190 from buildtools import xarfile	190 from buildtools import xarfile

191 xarfile.create(outFile, files, keyFile)	191 xarfile.create(outFile, files, keyFile)

192 else:	192 else:

193 files.zip(outFile)	193 files.zip(outFile)

LEFT	RIGHT