Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29349981: Noissue - Remove rules which match no resource types (Closed)

Created:
Aug. 19, 2016, 5:33 p.m. by kzar
Modified:
Aug. 22, 2016, 3:42 p.m.
Reviewers:
Sebastian Noack
Visibility:
Public.

Description

Noissue - Remove rules which match no resource types

Patch Set 1 #

Total comments: 4

Patch Set 2 : Remove redundant comment, use simpler test filters #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M lib/abp2blocklist.js View 1 1 chunk +6 lines, -0 lines 0 comments Download
M test/abp2blocklist.js View 1 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 4
kzar
Patch Set 1
Aug. 19, 2016, 5:34 p.m. (2016-08-19 17:34:35 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29349981/diff/29349982/lib/abp2blocklist.js File lib/abp2blocklist.js (right): https://codereview.adblockplus.org/29349981/diff/29349982/lib/abp2blocklist.js#newcode279 lib/abp2blocklist.js:279: // Rules with no resource types to match shouldn't ...
Aug. 20, 2016, 1:42 p.m. (2016-08-20 13:42:50 UTC) #2
kzar
Patch Set 2 : Remove redundant comment, use simpler test filters https://codereview.adblockplus.org/29349981/diff/29349982/lib/abp2blocklist.js File lib/abp2blocklist.js (right): ...
Aug. 22, 2016, 12:44 p.m. (2016-08-22 12:44:36 UTC) #3
Sebastian Noack
Aug. 22, 2016, 3:09 p.m. (2016-08-22 15:09:43 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld