Noissue - Remove rules which match no resource types

lib/abp2blocklist.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 255 matching lines @@
 
   if (parsed.canSafelyMatchAsLowercase || filter.matchCase)
     trigger["url-filter-is-case-sensitive"] = true;
 
   let included = [];
   let excluded = [];
 
   parseDomains(filter.domains, included, excluded);
 
   if (withResourceTypes)
+  {
     trigger["resource-type"] = getResourceTypes(filter);
+
+    // Rules with no resource types to match shouldn't match anything and

[Sebastian Noack, 2016/08/20 13:42:50]

Not sure whether this comment is necessary. Isn't it quite obvious if we return
here when there are no resource types?

[kzar, 2016/08/22 12:44:36]

Fair enough, removed.

+    // therefore shouldn't be created.
+    if (trigger["resource-type"].length == 0)
+      return;
+  }
+
   if (filter.thirdParty != null)
     trigger["load-type"] = [filter.thirdParty ? "third-party" : "first-party"];
 
   if (included.length > 0)
     trigger["if-domain"] = addDomainPrefix(included);
   else if (excluded.length > 0)
     trigger["unless-domain"] = addDomainPrefix(excluded);
 
   rules.push({trigger: trigger, action: {type: action}});
 }
@@ skipping 174 matching lines @@
 
   for (let filter of this.elemhideExceptions)
     convertFilterAddRules(rules, filter, "ignore-previous-rules", false);
   for (let filter of this.requestFilters)
     convertFilterAddRules(rules, filter, "block", true);
   for (let filter of this.requestExceptions)
     convertFilterAddRules(rules, filter, "ignore-previous-rules", true);
 
   return rules.filter(rule => !hasNonASCI(rule));
 };