Noissue - Remove rules which match no resource types

test/abp2blocklist.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 75 matching lines @@
 
     testRules(test, ["||example.com"], [
       {trigger: {"url-filter": "^https?://([^/]+\\.)?example\\.com",
                  "url-filter-is-case-sensitive": true,
                  "resource-type": ["image", "style-sheet", "script", "font",
                                    "media", "raw", "document"]},
 
        action: {type: "block"}}
     ]);
 
+    // Rules which would match no resource-types shouldn't be generated.
+    testRules(test, ["foo$~image,~stylesheet,~script,~font,~media,~object," +
+                     "~xmlhttprequest,~object_subrequest,~ping,~other," +

[Sebastian Noack, 2016/08/20 13:42:50]

It's document as $object-subrequest, with dash, not underscore. 

[kzar, 2016/08/22 12:44:36]

Good point, but since it's kind of a stupid test I instead replaced it with a
more concise one.

+                     "~subdocument", "foo$document"], []);
 
     test.done();
   },
 
   testRequestFilterExceptions: function(test)
   {
     testRules(test, ["@@example.com"], [
       {trigger: {"url-filter": "^https?://.*example\\.com",
                  "resource-type": ["image", "style-sheet", "script", "font",
                                    "media", "raw", "document"]},
@@ skipping 63 matching lines @@
 
     test.done();
   },
 
   testRequestTypeMapping: function(test)
   {
     testRules(
       test,
       ["1", "2$image", "3$stylesheet", "4$script", "5$font", "6$media",
        "7$popup", "8$object", "9$object_subrequest", "10$xmlhttprequest",
-       "11$ping", "12$subdocument", "13$other", "14$IMAGE", "15$document",
-       "16$script,PING,Popup", "17$~image"],
+       "11$ping", "12$subdocument", "13$other", "14$IMAGE",
+       "15$script,PING,Popup", "16$~image"],
       [["image", "style-sheet", "script", "font", "media", "raw", "document" ],
        ["image"],
        ["style-sheet"],
        ["script"],
        ["font"],
        ["media"],
        ["popup"],
        ["media"],
        ["raw"],
        ["raw"],
        ["raw"],
        ["document"],
        ["raw"],
        ["image"],
-       [],
        ["script", "popup", "raw" ],
        ["style-sheet", "script", "font", "media", "raw", "document"]],
       rules => rules.map(rule => rule.trigger["resource-type"])
     );
 
     test.done();
   },
 
   testUnsupportedfilters: function(test)
   {
@@ skipping 19 matching lines @@
   testUnicode: function(test)
   {
     testRules(test, ["$domain=🐈.cat"], ["xn--zn8h.cat", "www.xn--zn8h.cat"],
               rules => rules[0]["trigger"]["if-domain"]);
     testRules(test, ["🐈$domain=🐈.cat"], []);
     testRules(test, ["###🐈"], []);
 
     test.done();
   }
 };