Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: test/abp2blocklist.js

Issue 29349981: Noissue - Remove rules which match no resource types (Closed)
Patch Set: Remove redundant comment, use simpler test filters Created Aug. 22, 2016, 12:43 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/abp2blocklist.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/abp2blocklist.js
diff --git a/test/abp2blocklist.js b/test/abp2blocklist.js
index fbc4f7d752cae60a9c520c1ff2b886a5b25ebd2a..a7929ac6bb2377eb8a2f6840264f68cd093ea548 100644
--- a/test/abp2blocklist.js
+++ b/test/abp2blocklist.js
@@ -93,6 +93,8 @@ exports.generateRules = {
action: {type: "block"}}
]);
+ // Rules which would match no resource-types shouldn't be generated.
+ testRules(test, ["foo$document", "||foo.com$document"], []);
test.done();
},
@@ -176,8 +178,8 @@ exports.generateRules = {
test,
["1", "2$image", "3$stylesheet", "4$script", "5$font", "6$media",
"7$popup", "8$object", "9$object_subrequest", "10$xmlhttprequest",
- "11$ping", "12$subdocument", "13$other", "14$IMAGE", "15$document",
- "16$script,PING,Popup", "17$~image"],
+ "11$ping", "12$subdocument", "13$other", "14$IMAGE",
+ "15$script,PING,Popup", "16$~image"],
[["image", "style-sheet", "script", "font", "media", "raw", "document" ],
["image"],
["style-sheet"],
@@ -192,7 +194,6 @@ exports.generateRules = {
["document"],
["raw"],
["image"],
- [],
["script", "popup", "raw" ],
["style-sheet", "script", "font", "media", "raw", "document"]],
rules => rules.map(rule => rule.trigger["resource-type"])
« no previous file with comments | « lib/abp2blocklist.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld