Issue 4023 - Move storage of subscription lists to localStorage

lib/prefs.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 236 matching lines @@
         throw new Error("Attempt to change preference type");
 
       if (value == defaultValue)
       {
         delete overrides[pref];
         ext.storage.remove(prefToKey(pref));
       }
       else
       {
         overrides[pref] = value;
-        ext.storage.set(prefToKey(pref), value);
+
+        let items = {};
+        items[prefToKey(pref)] = value;
+        ext.storage.set(items);

[kzar, 2016/08/22 15:38:32]

I wonder if Edge supports (and JS Hydra doesn't mess up) the new syntax for
computed Object properties[1]? If so I think we could do something like this:
`ext.storage.set({[prefToKey(pref)]: value});`

[1] -
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/O...

[Oleksandr, 2016/08/25 02:02:38]

JS Hydra does not let this through.

       }
     },
     enumerable: true
   });
 }
 
 function init()
 {
   let prefs = Object.keys(defaults);
   prefs.forEach(addPreference);
@@ skipping 49 matching lines @@
           eventEmitter.emit(pref);
         }
       }
     });
   }
 
   Prefs.untilLoaded = Promise.all([localLoaded, managedLoaded]).then(onLoaded);
 }
 
 init();