Issue 4023 - Move storage of subscription lists to localStorage

lib/io.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 44 matching lines @@
   {
     return new FakeFile(path);
   },
 
   readFromFile: function(file, listener, callback)
   {
     function onLoaded(entry)
     {
       if ("content" in entry)
       {
-        if ("compressed" in entry)
+        if (entry["compressed"])
           entry.content = JSON.parse(LZString.decompressFromUTF16(entry.content));
         for (let line of entry.content)
           listener.process(line);
       }
       callback(null);
     }
 
     loadFile(file).then(onLoaded, callback);
   },
 
   writeToFile: function(file, data, callback)
   {
     let entry = {};
     let key = fileToKey(file);
 
-    // Edge cannot write files larger than 1Mb (500k string in UTF-16).

[kzar, 2016/08/30 14:13:02]

I think this comment should be inside the else block, since that's the Edge
related code.

[Oleksandr, 2016/08/31 21:54:37]

Done.

-    // However it does not always raise an exception when trying to do so.
     if (typeof browser == "undefined")
     {
-      entry[key] = {lastModified: Date.now(), 

[kzar, 2016/08/30 14:13:03]

Nit: No need to wrap this into two lines if it will fit on one.

[Oleksandr, 2016/08/31 21:54:37]

Done.

-                    content: data};
+      entry[key] = {lastModified: Date.now(), content: data};
       ext.storage.set(entry, callback);
     }
     else
     {
-      // Compress and fallback to localStorage
+      // Edge cannot write files larger than 1Mb (500k string in UTF-16) via 
+      // storage API. However it does not always raise an exception when trying
+      // to do so. The solution is to compress and fallback to localStorage.
       let processedData = LZString.compressToUTF16(JSON.stringify(data));
       ext.storage.remove(key);
-      entry[key] = {lastModified: Date.now(), 

[kzar, 2016/08/30 14:13:02]

Nit: This could fit on two lines instead of three.

[Oleksandr, 2016/08/31 21:54:37]

Done. However it looked better as it was, IMHO.

[kzar, 2016/09/01 12:57:37]

I can't see the change?

-                    content: processedData,
+      entry[key] = {lastModified: Date.now(), content: processedData,
                     compressed: true};
       window.localStorage.setItem(key, JSON.stringify(entry[key]));
       callback();
     }
   },
 
   statFile: function(file, callback)
   {
     function onLoaded(entry)
     {
       callback(null, {
         exists: true,
         lastModified: entry.lastModified
       });
     }
 
     loadFile(file).then(onLoaded, callback);
   }
 };