Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(192)

Issue 29350065: Issue 2853 - Settings changes are sometimes not saved if the user quits the app (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 1 month ago by diegocarloslima
Modified:
2 years, 8 months ago
Reviewers:
anton, Felix Dahlke
CC:
René Jeschke
Visibility:
Public.

Description

Issue 2853 - Settings changes are sometimes not saved if the user quits the app

Patch Set 1 #

Total comments: 10

Patch Set 2 : Adjusting spacing and also adding code change comment #

Total comments: 8

Patch Set 3 : Instead of pooling, adding observer for save operations performed by the extension #

Total comments: 6

Patch Set 4 : Fixing a bug where uncompleted requests could be sent out of order with the use of filter load pool… #

Patch Set 5 : Removing now unused getFiltersLoaded #

Total comments: 2

Patch Set 6 : Renaming 'uncompleted' to 'pending' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+218 lines, -92 lines) Patch
M adblockplus/Api.jsm View 1 2 3 4 2 chunks +19 lines, -3 lines 0 comments Download
M mobile/android/base/GeckoApplication.java View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M mobile/android/thirdparty/org/adblockplus/browser/AddOnBridge.java View 1 2 3 4 5 5 chunks +194 lines, -89 lines 0 comments Download

Messages

Total messages: 13
diegocarloslima
3 years, 1 month ago (2016-08-23 12:48:11 UTC) #1
anton
https://codereview.adblockplus.org/29350065/diff/29350066/adblockplus/Api.jsm File adblockplus/Api.jsm (right): https://codereview.adblockplus.org/29350065/diff/29350066/adblockplus/Api.jsm#newcode40 adblockplus/Api.jsm:40: let {FilterNotifier} = require("filterNotifier"); Please make sure it does ...
3 years ago (2016-09-30 06:51:04 UTC) #2
diegocarloslima
https://codereview.adblockplus.org/29350065/diff/29350066/adblockplus/Api.jsm File adblockplus/Api.jsm (right): https://codereview.adblockplus.org/29350065/diff/29350066/adblockplus/Api.jsm#newcode40 adblockplus/Api.jsm:40: let {FilterNotifier} = require("filterNotifier"); On 2016/09/30 06:51:03, anton wrote: ...
2 years, 11 months ago (2016-10-26 13:48:04 UTC) #3
anton
On 2016/10/26 13:48:04, diegocarloslima wrote: > https://codereview.adblockplus.org/29350065/diff/29350066/adblockplus/Api.jsm > File adblockplus/Api.jsm (right): > > https://codereview.adblockplus.org/29350065/diff/29350066/adblockplus/Api.jsm#newcode40 > ...
2 years, 11 months ago (2016-11-02 13:59:32 UTC) #4
Felix Dahlke
Bit puzzled about this one, but I might be missing something. Please look at my ...
2 years, 10 months ago (2016-12-13 11:25:10 UTC) #5
Felix Dahlke
LGTM pretty much, some nits for your consideration. https://codereview.adblockplus.org/29350065/diff/29369470/adblockplus/Api.jsm File adblockplus/Api.jsm (right): https://codereview.adblockplus.org/29350065/diff/29369470/adblockplus/Api.jsm#newcode176 adblockplus/Api.jsm:176: initListeners(); ...
2 years, 9 months ago (2016-12-21 20:23:26 UTC) #6
diegocarloslima
https://codereview.adblockplus.org/29350065/diff/29369470/adblockplus/Api.jsm File adblockplus/Api.jsm (right): https://codereview.adblockplus.org/29350065/diff/29369470/adblockplus/Api.jsm#newcode176 adblockplus/Api.jsm:176: initListeners(); On 2016/12/21 20:23:25, Felix Dahlke wrote: > Nit: ...
2 years, 9 months ago (2016-12-21 20:29:31 UTC) #7
Felix Dahlke
https://codereview.adblockplus.org/29350065/diff/29369470/adblockplus/Api.jsm File adblockplus/Api.jsm (right): https://codereview.adblockplus.org/29350065/diff/29369470/adblockplus/Api.jsm#newcode176 adblockplus/Api.jsm:176: initListeners(); On 2016/12/21 20:29:31, diegocarloslima wrote: > On 2016/12/21 ...
2 years, 9 months ago (2016-12-21 20:36:20 UTC) #8
diegocarloslima
https://codereview.adblockplus.org/29350065/diff/29369470/adblockplus/Api.jsm File adblockplus/Api.jsm (right): https://codereview.adblockplus.org/29350065/diff/29369470/adblockplus/Api.jsm#newcode176 adblockplus/Api.jsm:176: initListeners(); On 2016/12/21 20:36:20, Felix Dahlke wrote: > On ...
2 years, 9 months ago (2016-12-21 20:42:03 UTC) #9
anton
On 2016/12/21 20:42:03, diegocarloslima wrote: > https://codereview.adblockplus.org/29350065/diff/29369470/adblockplus/Api.jsm > File adblockplus/Api.jsm (right): > > https://codereview.adblockplus.org/29350065/diff/29369470/adblockplus/Api.jsm#newcode176 > ...
2 years, 8 months ago (2017-01-24 05:52:13 UTC) #10
Felix Dahlke
https://codereview.adblockplus.org/29350065/diff/29369547/mobile/android/thirdparty/org/adblockplus/browser/AddOnBridge.java File mobile/android/thirdparty/org/adblockplus/browser/AddOnBridge.java (right): https://codereview.adblockplus.org/29350065/diff/29369547/mobile/android/thirdparty/org/adblockplus/browser/AddOnBridge.java#newcode60 mobile/android/thirdparty/org/adblockplus/browser/AddOnBridge.java:60: private static final List<AddOnRequest> PENDING_REQUESTS = new ArrayList<>(); You've ...
2 years, 8 months ago (2017-01-30 15:37:53 UTC) #11
diegocarloslima
https://codereview.adblockplus.org/29350065/diff/29369547/mobile/android/thirdparty/org/adblockplus/browser/AddOnBridge.java File mobile/android/thirdparty/org/adblockplus/browser/AddOnBridge.java (right): https://codereview.adblockplus.org/29350065/diff/29369547/mobile/android/thirdparty/org/adblockplus/browser/AddOnBridge.java#newcode60 mobile/android/thirdparty/org/adblockplus/browser/AddOnBridge.java:60: private static final List<AddOnRequest> PENDING_REQUESTS = new ArrayList<>(); On ...
2 years, 8 months ago (2017-01-30 17:12:43 UTC) #12
Felix Dahlke
2 years, 8 months ago (2017-02-09 14:18:34 UTC) #13
Nice, LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5