Issue 2853 - Settings changes are sometimes not saved if the user quits the app

adblockplus/Api.jsm

Index: adblockplus/Api.jsm
===================================================================
--- a/adblockplus/Api.jsm
+++ b/adblockplus/Api.jsm
@@ -32,23 +32,34 @@ function require(module)
 {
   let result = {};
   result.wrappedJSObject = result;
   Services.obs.notifyObservers(result, "adblockplus-require", module);
   return result.exports;
 }
 
 let {Filter} = require("filterClasses");
+let {FilterNotifier} = require("filterNotifier");
 let {FilterStorage} = require("filterStorage");
 let {defaultMatcher} = require("matcher");
 let {Prefs} = require("prefs");
 let {Subscription, SpecialSubscription, RegularSubscription, DownloadableSubscription, ExternalSubscription} = require("subscriptionClasses");
 let {Synchronizer} = require("synchronizer");
 let {UI} = require("ui");
 
+function initListeners()
+{
+  FilterNotifier.on("save", onSave);
+}
+
+function onSave()
+{
+  Messaging.sendRequest({ type: "Abb:OnSave" });
+}
+
 function getWhitelistingFilter(url)
 {
   let uriObject = Services.io.newURI(url, null, null);
   try
   {
     return defaultMatcher.whitelist.matchesAny(
       uriObject.spec, "DOCUMENT", uriObject.host, false, null);
   }
@@ -157,16 +168,18 @@ var AdblockPlusApi =
         if (filter.subscriptions.length)
           filter.disabled = true;
         filter = getWhitelistingFilter(url);
       }
     }
   },
   initCommunication: function()
   {
+    initListeners();

[Felix Dahlke, 2016/12/21 20:23:25]

Nit: Considering how there's only a single listener and only a single line
needed to register it, how about inlining this?

[diegocarloslima, 2016/12/21 20:29:31]

Actually there is another listener that is already registered by Issue #3247. So
this is required to keep consistency

[Felix Dahlke, 2016/12/21 20:36:20]

Oh, so it seems you need to rebase this patch? Think I suggested to call that
function `initFilterListeners` then for clarity's sake.

[diegocarloslima, 2016/12/21 20:42:03]

Acknowledged.

+
     Messaging.addListener((function(data)
     {
       if (!data)
         return {"success": false, "error": "malformed request"};
 
       if (data["action"] == "getFiltersLoaded")
         return {"success": true, "value": this.filtersLoaded};