Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29350121: Noissue - Add punycode dependency explicitly (Closed)

Created:
Aug. 23, 2016, 6:06 p.m. by kzar
Modified:
Aug. 23, 2016, 6:23 p.m.
Reviewers:
Sebastian Noack
Visibility:
Public.

Description

Noissue - Add punycode dependency explicitly

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M package.json View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2
kzar
Patch Set 1
Aug. 23, 2016, 6:06 p.m. (2016-08-23 18:06:47 UTC) #1
Sebastian Noack
Aug. 23, 2016, 6:16 p.m. (2016-08-23 18:16:17 UTC) #2
For reference, the built-in "punycode" module is deprecated starting with
node.js v7. Ideally, the commit message should contain this information.

LGTM

Powered by Google App Engine
This is Rietveld