Issue 4353 - Remove non standard for each syntax

scripts/decompile.js

 // Decompile a JS file. This will be painful.

[Wladimir Palant, 2016/08/24 14:21:50]

I don't consider it a good measure to modify files that we don't use and
consequently cannot really test. Everything modified here other than
astDecompile.js is dead code now, it should be better to remove it.

[kzar, 2016/08/24 14:43:20]

Done.

 include("../utils/dumpast.js");
 include("../utils/astml.js");
 
 let visitor = {
   _visitArray: function (arr, pre, post, comma) {
     if (pre === undefined) pre = '(';
     if (post === undefined) post = ')';
     if (comma === undefined) comma = ', ';
     output(pre);
-    for each (let arg in arr) {
+    for (let arg of arr) {
       arg.visit(this);
       output(comma);
     }
     if (arr.length > 0)
       unwrite(comma.length);
     output(post);
   },
   _visitMaybeBlock: function (body) {
     if (body.type == "BlockStatement") {
       output(" ");
       body.visit(this);
     } else {
       flush().indent();
       body.visit(this);
       unindent();
     }
   },
   _visitNeedBlock: function (stmt, noFlush) {
     if (stmt.type == "EmptyStatement") {
-      output("{}")
+      output("{}");
       if (!noFlush)
         flush();
     }
     else if (stmt.type == "ReturnStatement") {
       output("{").flush().indent();
       stmt.visit(this);
       unindent().output("}");
       if (!noFlush)
         flush();
     }
@@ skipping 397 matching lines @@
 function sanitize(str, q) {
   function replace(x) {
     if (x == q) return '\\' + q;
     if (x == '\\') return '\\\\';
     if (x == '\b') return '\\b';
     if (x == '\f') return '\\f';
     if (x == '\n') return '\\n';
     if (x == '\r') return '\\r';
     if (x == '\t') return '\\t';
     if (x == '\v') return '\\v';
-    let val = x.charCodeAt(0)
+    let val = x.charCodeAt(0);
     if (x < ' ') return '\\x' + (val - val % 16) / 16 + (val % 16);
     return x;
   }
-  return [replace(x) for each (x in str)].join('');
+
+  let result = "";
+  for (let char of str)
+    result += replace(char);
+  return result;
 }