Issue 4353 - Remove non standard for each syntax

scripts/astDecompile.js

 let global = this;
 function decompileAST(ast) {
   let func = global["decompile" + ast.type];
   if (!func)
     throw "Unknown type " + ast.type;
   return func(ast);
 }
 
 function decompileProgram(ast) {
   return ast.body.map(decompileAST).join('\n');
@@ skipping 386 matching lines @@
 }
 
 function decompileLiteral(ast) {
   if (typeof ast.value == "string")
     return '"' + sanitize(ast.value, '"') + '"';
   if (ast.value === null)
       return "null";
   return ast.value;
 }
 
-/* E4X */
-function decompileXMLDefaultDeclaration(ast) {
-  return "default xml namespace = " + decompileAST(ast.namespace) + ";";
-}
-
-function decompileXMLAnyName(ast) {
-  return "*";
-}
-
-function decompileXMLQualifiedIdentifier(ast) {
-  let str = decompileAST(ast.left) + "::";
-  if (ast.computed)
-    str += "[";
-  str += decompileAST(ast.right);
-  if (ast.computed)
-    str += "]";
-  return str;
-}
-
-function decompileXMLFunctionQualifiedIdentifier(ast) {
-  let str = "function::";
-  if (ast.computed)
-    str += "[";
-  str += decompileAST(ast.right);
-  if (ast.computed)
-    str += "]";
-  return str;
-}
-
-function decompileXMLAttributeSelector(ast) {
-  return "@" + decompileAST(ast.attribute);
-}
-
-function decompileXMLFilterExpression(ast) {
-  return decompileAST(ast.left) + ".(" + decompileAST(ast.right) + ")";
-}
-
-function decompileXMLElement(ast) {
-  return  ast.contents.map(decompileAST).join('');
-}
-
-function decompileXMLList(ast) {
-  return "<>" +   ast.contents.map(decompileAST).join("") + "</>";

[Wladimir Palant, 2016/08/24 14:21:50]

Nit: You've added unnecessary whitespace here.

[kzar, 2016/08/24 14:43:20]

Done.

-}
-
-function decompileXMLEscape(ast) {
-  return "{" + decompileAST(ast.expression) + "}";
-}
-
-function decompileXMLText(ast) {
-  return ast.text;
-}
-
-function tagJoin(strings) {
-  let str = strings[0];
-  for (let i = 1; i < strings.length; i++)
-    str += (i % 2 ? ' ' : '=') + strings[i];
-  return str;
-}
-
-function decompileXMLStartTag(ast) {
-  return "<" + tagJoin(ast.contents.map(decompileAST)) + ">";
-}
-
-function decompileXMLEndTag(ast) {
-  return "</" + tagJoin(ast.contents.map(decompileAST)) + ">";
-}
-
-function decompileXMLPointTag(ast) {
-  return "<" + tagJoin(ast.contents.map(decompileAST)) + "/>";
-}
-
-function decompileXMLName(ast) {
-  if (typeof ast.contents == "string")
-    return ast.contents + " ";
-  return ast.contents.map(decompileAST).join('');
-}
-
-function decompileXMLAttribute(ast) {
-  return '"' + ast.value + '"';
-}
-
-function decompileXMLCdata(ast) {
-  return "<![CDATA[" + ast.contents + "]]>";
-}
-
-function decompileXMLComment(ast) {
-  return "<!--" + ast.comment + "-->";
-}
-
-function decompileXMLProcessingInstruction(ast) {
-  return "<?" + ast.target + (ast.contents ? " " + ast.contents : "") + "?>";
-}

[Wladimir Palant, 2016/08/24 14:21:50]

It's probably better to just remove all functions related to XML literals -
these are no longer supported by SpiderMonkey (yes,
https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/Parser...
appears to be outdated in this respect). So everything starting with `/* E4X */`
until this function can go.

[kzar, 2016/08/24 14:43:20]

Done.

-
 function process_js(ast) {
     _print(decompileAST(ast));
 }