Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(10)

Issue 29350155: Issue 4353 - Fix syntax for modern Js Shell (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years ago by kzar
Modified:
3 years ago
Reviewers:
Sebastian Noack
Visibility:
Public.

Description

Issue 4353 - Fix syntax for modern Js Shell

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M lib/icon.js View 2 chunks +3 lines, -3 lines 2 comments Download

Messages

Total messages: 4
kzar
Patch Set 1
3 years ago (2016-08-24 11:12:58 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29350155/diff/29350156/lib/icon.js File lib/icon.js (right): https://codereview.adblockplus.org/29350155/diff/29350156/lib/icon.js#newcode108 lib/icon.js:108: let imageMap = { Why must this variable no ...
3 years ago (2016-08-24 11:30:04 UTC) #2
kzar
https://codereview.adblockplus.org/29350155/diff/29350156/lib/icon.js File lib/icon.js (right): https://codereview.adblockplus.org/29350155/diff/29350156/lib/icon.js#newcode108 lib/icon.js:108: let imageMap = { On 2016/08/24 11:30:04, Sebastian Noack ...
3 years ago (2016-08-24 12:24:43 UTC) #3
Sebastian Noack
3 years ago (2016-09-13 14:40:06 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5