Issue 4353 - Update Js Shell to version 45

scripts/abprewrite.js

 // This script rewrites AST to be compatible with JavaScript 1.5 and decompiles
 // the modified tree then
 
 include("../scripts/astDecompile.js");
 include("../utils/beautify.js");
 
 let headerPrinted = false;
 
 // See https://developer.mozilla.org/en-US/docs/SpiderMonkey/Parser_API for
 // AST structure.
 
 let options = {
   filename: null,
   module: false,
   autoload: "",
   varIndex: 0,
   indent_size: 2,
   preserve_newlines: false,
   brace_style: "expand",
   source_repo: ""
 };
-let global = this;
 
 function Literal(value)
 {
   return {
     type: "Literal",
     value: value
   };
 }
 
 function Identifier(varname)
@@ skipping 89 matching lines @@
     return ast;
   else
     return {type: "BlockStatement", body: (ast.type == "EmptyStatement" ? [] : [ast])};
 }
 
 function modifyAST(ast)
 {
   // Do the necessary modifications
   let func = "modify" + ast.type;
   if (typeof global[func] == "function")
     ast = global[func](ast);

[Wladimir Palant, 2016/08/24 14:08:36]

How is this working now? You removed the `global` variable, and I don't see it
being listed as predefined on
https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/Shell_....

[kzar, 2016/08/24 14:25:20]

`global` is already defined in astDecompile.js which is included by this script.
I removed it here since otherwise I got an error "TypeError: redeclaration of
let global".

[Wladimir Palant, 2016/08/24 14:45:17]

Ok, this is really awkward... This should really be a lookup table, so that
fetching functions from global scope wouldn't be necessary.

[kzar, 2016/09/13 13:35:20]

I agree this is awkward, but I don't understand what you're suggesting. What
should I change?

[Wladimir Palant, 2016/09/13 14:22:59]

I'm not actually suggesting anything at this point, I guess we'll need to leave
this as is for now :-(

 
   // Recursive calls for any AST in properties of the current one
   if (ast)
   {
     let props = [];
     for (let prop in ast)
       props.push(prop);
     for (let i = 0; i < props.length; i++)
     {
       let value = ast[props[i]];
@@ skipping 286 matching lines @@
   }
 
   return ast;
 }
 
 function modifyFunctionDeclaration(ast)
 {
   return modifyFunctionExpression(ast);
 }
 
-function modifyArrowExpression(ast)
+function modifyArrowFunctionExpression(ast)
 {
   if (ast.body.type != "BlockStatement") {
     // Convert expressions to block statements.
     // (a) => a + 1
     //
     // Change into:
     // (a) => { return a + 1; }
     ast.body = {
       type: "BlockStatement",
       body: [
@@ skipping 130 matching lines @@
     _print(decompileAST({
       type: "ExpressionStatement",
       expression: {
         type: "CallExpression",
         callee: Identifier("require"),
         arguments: [Literal(module)]
       }
     }));
   }
 };