Issue 4373 - Made jshydra compatible with Python 3

utils.py

 # This Source Code is subject to the terms of the Mozilla Public License
 # version 2.0 (the "License"). You can obtain a copy of the License at
 # http://mozilla.org/MPL/2.0/.
 
 import os
 import platform
 import io
 import zipfile
 
 try:
     from urllib.request import urlopen
 except ImportError:
-    import urllib
+    import urllib2

[Sebastian Noack, 2016/08/30 11:44:39]

It seems more resonable to fallback to urllib2 (rather than urllib) on Python 2,
since it is closer to the semantics of urllib.request on Python 3, e.g. it
raises when encountering bad HTTP responses.

[Vasily Kuznetsov, 2016/08/30 13:16:30]

Acknowledged.

     import contextlib
 
     def urlopen(*args, **kwargs):
-        return contextlib.closing(urllib.urlopen(*args, **kwargs))
+        return contextlib.closing(urllib2.urlopen(*args, **kwargs))
 
 JSSHELL_DIR = 'mozilla-esr31'
 JSSHELL_URL = ('https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly'
                '/2015/02/2015-02-25-00-22-19-{}'
                '/jsshell-{{}}.zip'.format(JSSHELL_DIR))
 
 JSSHELL_SUPPORTED_PLATFORMS = {
     'Windows': 'win32',
     'Linux': {
         'i686': 'linux-i686',
         'x86_64': 'linux-x86_64'
     },
     'Darwin': 'mac'
 }
 
 
 def ensureJSShell():
     path = os.environ.get('SPIDERMONKEY_BINARY')
     if path and os.path.isfile(path):
         return path
 
     baseDir = os.path.dirname(__file__)
     system = platform.system()

[Sebastian Noack, 2016/08/28 22:36:14]

sys.platform behaves inconsistently since Python 3.3 and before. The value for
Linux changed from 'linux2' to 'linux'. However, platform.system() isn't
effected and can be used instead, without any compatibility hack.

[Vasily Kuznetsov, 2016/08/29 15:29:52]

Acknowledged.

 
     try:
         build = JSSHELL_SUPPORTED_PLATFORMS[system]
         if isinstance(build, dict):
             build = build[platform.machine()]
     except KeyError:
         raise Exception('Platform {} ({}) not supported by JS shell'.format(
             system, platform.machine()
         ))
 
@@ skipping 16 matching lines @@
 
     if not os.path.exists(path):
         raise Exception('Downloaded package didn\'t contain JS shell executable')
 
     try:
         os.chmod(path, 0o700)
     except:
         pass
 
     return path