Issue 4374 - Made Python code part of jshydra comply with our coding practices

abp_rewrite.py

 # This Source Code is subject to the terms of the Mozilla Public License
 # version 2.0 (the "License"). You can obtain a copy of the License at
 # http://mozilla.org/MPL/2.0/.
-
-from __future__ import print_function
 
 import os
 import platform

[Sebastian Noack, 2016/08/28 22:51:56]

All I did with patchset #2 is removing utils.py and inserting the code unchanged
here. I just did it with a separate patch set, so that it doesn't obfuscate the
review, as you can see the actual changes to this code on patch set #1.

Moving the code here wasn't strictly necessary to make it pass flake8, however
after the changes in the previous patch, adding Python 3 support, it arguably
doesn't make much sense anymore to have that code in two separate modules.

 import io
 import zipfile
 import subprocess
 
 try:
     from urllib.request import urlopen
 except ImportError:
-    import urllib
+    import urllib2
     import contextlib
 
     def urlopen(*args, **kwargs):
-        return contextlib.closing(urllib.urlopen(*args, **kwargs))
+        return contextlib.closing(urllib2.urlopen(*args, **kwargs))
 
 JSSHELL_DIR = 'mozilla-esr31'
 JSSHELL_URL = ('https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly'
                '/2015/02/2015-02-25-00-22-19-{}'
                '/jsshell-{{}}.zip'.format(JSSHELL_DIR))
 
 JSSHELL_SUPPORTED_PLATFORMS = {
     'Windows': 'win32',
     'Linux': {
         'i686': 'linux-i686',
@@ skipping 50 matching lines @@
 def rewrite_js(args, script=None):
     jsshell = ensure_jsshell()
     env = {'LD_LIBRARY_PATH': os.path.relpath(os.path.dirname(jsshell))}
     base_dir = os.path.dirname(__file__)
 
     if not script:
         script = os.path.join(base_dir, 'scripts', 'abprewrite.js')
 
     command = [jsshell, os.path.join(base_dir, 'jshydra.js'), script] + args
     return subprocess.check_output(command, env=env, universal_newlines=True)