Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(176)

Issue 29350286: Issue 4376 - Updated buildtools dependency (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 3 months ago by Sebastian Noack
Modified:
3 years, 2 months ago
Reviewers:
kzar
CC:
Vasily Kuznetsov
Visibility:
Public.

Description

Issue 4376 - Updated buildtools dependency

Patch Set 1 #

Total comments: 6

Patch Set 2 : Rebased, set revisions, tidy up metadata.safari #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -21 lines) Patch
M README.md View 1 chunk +1 line, -2 lines 0 comments Download
M dependencies View 1 1 chunk +1 line, -1 line 0 comments Download
M ensure_dependencies.py View 1 2 chunks +2 lines, -2 lines 0 comments Download
M metadata.chrome View 1 chunk +3 lines, -1 line 0 comments Download
M metadata.common View 3 chunks +7 lines, -10 lines 0 comments Download
M metadata.safari View 1 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 6
Sebastian Noack
https://codereview.adblockplus.org/29350286/diff/29350287/dependencies File dependencies (right): https://codereview.adblockplus.org/29350286/diff/29350287/dependencies#newcode3 dependencies:3: buildtools = hg:file:///home/sebastian/src/buildtools@6679f4a8bd41 Temporary hack to test the changes ...
3 years, 3 months ago (2016-08-29 10:16:41 UTC) #1
kzar
https://codereview.adblockplus.org/29350286/diff/29350287/dependencies File dependencies (right): https://codereview.adblockplus.org/29350286/diff/29350287/dependencies#newcode3 dependencies:3: buildtools = hg:file:///home/sebastian/src/buildtools@6679f4a8bd41 On 2016/08/29 10:16:41, Sebastian Noack wrote: ...
3 years, 3 months ago (2016-08-30 13:44:00 UTC) #2
Sebastian Noack
https://codereview.adblockplus.org/29350286/diff/29350287/metadata.safari File metadata.safari (right): https://codereview.adblockplus.org/29350286/diff/29350287/metadata.safari#newcode10 metadata.safari:10: document_start = ext/common.js ext/content.js cssProperties.js include.preload.js include.youtube.js On 2016/08/30 ...
3 years, 3 months ago (2016-08-30 13:46:33 UTC) #3
kzar
LGTM https://codereview.adblockplus.org/29350286/diff/29350287/metadata.safari File metadata.safari (right): https://codereview.adblockplus.org/29350286/diff/29350287/metadata.safari#newcode10 metadata.safari:10: document_start = ext/common.js ext/content.js cssProperties.js include.preload.js include.youtube.js On ...
3 years, 3 months ago (2016-08-30 14:15:17 UTC) #4
Sebastian Noack
https://codereview.adblockplus.org/29350286/diff/29350287/metadata.safari File metadata.safari (right): https://codereview.adblockplus.org/29350286/diff/29350287/metadata.safari#newcode10 metadata.safari:10: document_start = ext/common.js ext/content.js cssProperties.js include.preload.js include.youtube.js On 2016/08/30 ...
3 years, 2 months ago (2016-09-09 15:04:35 UTC) #5
kzar
3 years, 2 months ago (2016-09-13 12:53:50 UTC) #6
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5