Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: chrome/ext/background.js

Issue 29350379: Issue 4386 - Update frame URL after redirection (Closed)
Patch Set: Created Sept. 1, 2016, 1:37 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/ext/background.js
diff --git a/chrome/ext/background.js b/chrome/ext/background.js
index 810e7650c08d123c66210f317422b38b69acc895..d7cef14ca642cb9c75743f66c636ded9829b057f 100644
--- a/chrome/ext/background.js
+++ b/chrome/ext/background.js
@@ -147,6 +147,15 @@
};
});
+ chrome.webNavigation.onCommitted.addListener(function(details)
+ {
kzar 2016/09/01 13:42:07 (We could also check that details.transitionQualif
+ // onBeforeNavigate is fired before redirections take place, so we must
+ // ensure the frame's URL is correct here too. (See #4386)
+ var frames = framesOfTabs[details.tabId];
+ if (frames && details.frameId in frames)
+ frames[details.frameId].url = new URL(details.url);
+ });
+
function forgetTab(tabId)
{
ext.pages.onRemoved._dispatch(tabId);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld