Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(218)

Issue 29350382: Issue 4353 - Remove deprecated __proto__ syntax (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years ago by kzar
Modified:
3 years ago
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Issue 4353 - Remove deprecated __proto__ syntax

Patch Set 1 #

Patch Set 2 : Missed a file... #

Total comments: 2

Patch Set 3 : Make use of Object.getOwnPropertyDescriptor #

Total comments: 4

Patch Set 4 : Export extend function too, use Object.keys #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -78 lines) Patch
A lib/coreUtils.js View 1 2 3 1 chunk +34 lines, -0 lines 0 comments Download
M lib/filterClasses.js View 1 2 3 17 chunks +21 lines, -50 lines 0 comments Download
M lib/filterNotifier.js View 3 chunks +3 lines, -5 lines 0 comments Download
M lib/subscriptionClasses.js View 1 2 3 9 chunks +11 lines, -23 lines 0 comments Download

Messages

Total messages: 7
kzar
Patch Set 1
3 years ago (2016-09-01 23:46:06 UTC) #1
kzar
Patch Set 2 : Missed a file...
3 years ago (2016-09-01 23:52:54 UTC) #2
Wladimir Palant
https://codereview.adblockplus.org/29350382/diff/29350393/lib/coreUtils.js File lib/coreUtils.js (right): https://codereview.adblockplus.org/29350382/diff/29350393/lib/coreUtils.js#newcode27 lib/coreUtils.js:27: value["configurable"] = value["enumerable"] = true; How about just calling ...
3 years ago (2016-09-02 08:17:13 UTC) #3
kzar
Patch Set 3 : Make use of Object.getOwnPropertyDescriptor https://codereview.adblockplus.org/29350382/diff/29350393/lib/coreUtils.js File lib/coreUtils.js (right): https://codereview.adblockplus.org/29350382/diff/29350393/lib/coreUtils.js#newcode27 lib/coreUtils.js:27: value["configurable"] ...
3 years ago (2016-09-02 11:53:21 UTC) #4
Wladimir Palant
https://codereview.adblockplus.org/29350382/diff/29350436/lib/coreUtils.js File lib/coreUtils.js (right): https://codereview.adblockplus.org/29350382/diff/29350436/lib/coreUtils.js#newcode18 lib/coreUtils.js:18: function desc(properties) Since we are only using this for ...
3 years ago (2016-09-02 12:19:48 UTC) #5
kzar
Patch Set 4 : Export extend function too, use Object.keys https://codereview.adblockplus.org/29350382/diff/29350436/lib/coreUtils.js File lib/coreUtils.js (right): https://codereview.adblockplus.org/29350382/diff/29350436/lib/coreUtils.js#newcode18 ...
3 years ago (2016-09-02 15:06:41 UTC) #6
Wladimir Palant
3 years ago (2016-09-02 20:43:28 UTC) #7
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5