Noissue - Add tests for formmail handler

sitescripts/formmail/test/test_formmail.py

 # This file is part of the Adblock Plus web scripts,
 # Copyright (C) 2006-2016 Eyeo GmbH
 #
 # Adblock Plus is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License version 3 as
 # published by the Free Software Foundation.
 #
 # Adblock Plus is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 # GNU General Public License for more details.
 #
 # You should have received a copy of the GNU General Public License
 # along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
 
-import pytest

[Sebastian Noack, 2016/09/02 15:09:08]

corelib imports go first. Third party- modules follow after a blank line.

[Vasily Kuznetsov, 2016/09/02 15:44:30]

Done.

 from urllib import urlencode
 from urllib2 import urlopen
+
+import pytest
 from wsgi_intercept import (urllib_intercept, add_wsgi_intercept,
                             remove_wsgi_intercept)
 
 from sitescripts.formmail.web.formmail import handleRequest
 
 
 # We make this a fixture instead of a constant so we can modify it in each
 # test as needed without affecting other tests.
 @pytest.fixture
 def form_data():
@@ skipping 54 matching lines @@
 
 
 def test_success(response_for, form_data, mocker):
     sm_mock = mocker.patch('sitescripts.formmail.web.formmail.sendMail')
     assert response_for(form_data) == 'Message sent'
     assert sm_mock.call_count == 1
     params = sm_mock.call_args[0][1]
     assert set(params.keys()) == set(form_data.keys()) | {'time'}
     for key, value in form_data.items():
         assert params[key] == value