Issue 4399 - Add WebView inheritor with ad blocking

libadblockplus-android/src/org/adblockplus/android/AndroidWebRequest.java

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 74 matching lines @@
       connection.connect();
 
       final ServerResponse response = new ServerResponse();
       response.setResponseStatus(connection.getResponseCode());
 
       if (response.getResponseStatus() == 200)
       {
         final BufferedReader reader = new BufferedReader(new InputStreamReader(connection.getInputStream(), "UTF-8"));
         final StringBuilder sb = new StringBuilder();
 
-        if (!this.elemhideEnabled && isListedSubscriptionUrl(url))
+        String line;
+        while ((line = reader.readLine()) != null)
         {
-          Log.d(TAG, "Removing element hiding rules from: '" + url + "'");
-
-          String line;
-          while ((line = reader.readLine()) != null)
+          // We're only appending non-element-hiding filters here.
+          //
+          // See:
+          //      https://issues.adblockplus.org/ticket/303
+          //
+          // Follow-up issue for removing this hack:
+          //      https://issues.adblockplus.org/ticket/1541
+          //
+          if (this.elemhideEnabled || !isListedSubscriptionUrl(url) || line.indexOf('#') == -1)

[anton, 2016/09/08 13:00:12]

it was extremely bad idea to read bytes one-by-one because of low performance.
I've changed it to reading line-by-line and not excluding elemhide rules if not
asked for it

           {
-            // We're only appending non-element-hiding filters here.
-            //
-            // See:
-            //      https://issues.adblockplus.org/ticket/303
-            //
-            // Follow-up issue for removing this hack:
-            //      https://issues.adblockplus.org/ticket/1541
-            //
-            if (line.indexOf('#') == -1)
-            {
-              sb.append(line);
-              sb.append('\n');
-            }
-          }
-        }
-        else
-        {
-          int character;
-
-          while ((character = reader.read()) != -1)
-          {
-            sb.append((char) character);
+            sb.append(line);
+            sb.append('\n');
           }
         }
 
         connection.disconnect();
 
         response.setStatus(NsStatus.OK);
         response.setResponse(sb.toString());
       }
       else
       {
         response.setStatus(NsStatus.ERROR_FAILURE);
       }
+      Log.d(TAG, "Downloading finished");
       return response;
     }
     catch (final Throwable t)
     {
+      Log.e(TAG, "WebRequest failed", t);
       throw new AdblockPlusException("WebRequest failed", t);
     }
   }
 }