Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Side by Side Diff: settings.gradle
Issue
29351744
:
Issue 4399 - Add WebView inheritor with ad blocking (Closed)
Patch Set: updated README
Created Sept. 14, 2016, 11:43 a.m.
Left:
Base
Patch Set 1: None
Patch Set 2: updated README
Patch Set 3: removed gradlew.bat - it relates to issue-4324
Patch Set 4: now loading elemhide selectors beforehand in bg thread
Patch Set 5: yet another improvement - working with null urls (for local files)
Patch Set 6: added goBack/goForward support, added 'setAAenabled' setting, modified app for testing
Patch Set 7: stopping for fast redirection
Patch Set 8: supporting api 21 with referer and pre-21 with no referer
Patch Set 9: updated Ant/Maven build configuration files
Patch Set 10: moved AdblockWebView to separate module
Patch Set 11: added Maven build configuration files for -webview and -webviewapp modules
Patch Set 12: added current url as referer for main frame
Patch Set 13: moved from experimental gradle plugin to standard one (with new ndk support)
Patch Set 14: added enabled/disabled property
Patch Set 15: get 'isMainFrame' for android-pre-21 and #4518 fix
Patch Set 16: fixed #4543
Patch Set 17: minor codestyle fixes
Patch Set 18: fixed: hardcoded js bridge name
Patch Set 19: changed packages, now using AdblockEngine (original ABPEngine), improved demo app
Right:
Patch Set 1: None
Patch Set 2: updated README
Patch Set 3: removed gradlew.bat - it relates to issue-4324
Patch Set 4: now loading elemhide selectors beforehand in bg thread
Patch Set 5: yet another improvement - working with null urls (for local files)
Patch Set 6: added goBack/goForward support, added 'setAAenabled' setting, modified app for testing
Patch Set 7: stopping for fast redirection
Patch Set 8: supporting api 21 with referer and pre-21 with no referer
Patch Set 9: updated Ant/Maven build configuration files
Patch Set 10: moved AdblockWebView to separate module
Patch Set 11: added Maven build configuration files for -webview and -webviewapp modules
Patch Set 12: added current url as referer for main frame
Patch Set 13: moved from experimental gradle plugin to standard one (with new ndk support)
Patch Set 14: added enabled/disabled property
Patch Set 15: get 'isMainFrame' for android-pre-21 and #4518 fix
Patch Set 16: fixed #4543
Patch Set 17: minor codestyle fixes
Patch Set 18: fixed: hardcoded js bridge name
Patch Set 19: changed packages, now using AdblockEngine (original ABPEngine), improved demo app
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
.gitignore
README.md
gradlew.bat
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AndroidWebRequestTest.java
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/UtilsTest.java
libadblockplus-android-webviewapp/AndroidManifest.xml
libadblockplus-android-webviewapp/build.gradle
libadblockplus-android-webviewapp/build.xml
libadblockplus-android-webviewapp/project.properties
libadblockplus-android-webviewapp/res/drawable/icon.png
libadblockplus-android-webviewapp/res/layout/activity_main.xml
libadblockplus-android-webviewapp/res/values/strings.xml
libadblockplus-android-webviewapp/src/org/adblockplus/libadblockplus/webviewapp/MainActivity.java
libadblockplus-android/assets/css.js
libadblockplus-android/assets/empty.js
libadblockplus-android/assets/hide.js
libadblockplus-android/assets/inject.js
libadblockplus-android/build.gradle
libadblockplus-android/build.xml
libadblockplus-android/pom.xml
libadblockplus-android/project.properties
libadblockplus-android/src/org/adblockplus/android/AdblockWebView.java
libadblockplus-android/src/org/adblockplus/android/AndroidWebRequest.java
libadblockplus-android/src/org/adblockplus/android/Utils.java
settings.gradle
View unified diff
|
Download patch
« libadblockplus-android-webviewapp/res/layout/activity_main.xml
('K') |
« libadblockplus-android/src/org/adblockplus/android/Utils.java
('k') |
no next file »
|
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1 include ':libadblockplus-android'
1 include ':libadblockplus-android'
2
include ':libadblockplus-android-webviewapp'
2 include ':libadblockplus-android-tests'
3 include ':libadblockplus-android-tests'
OLD
NEW
« libadblockplus-android-webviewapp/res/layout/activity_main.xml
('K') |
« libadblockplus-android/src/org/adblockplus/android/Utils.java
('k') |
no next file »
|
no next file with comments »
Edit Message
Issue 29351744: Issue 4399 - Add WebView inheritor with ad blocking (Closed)
Created Sept. 8, 2016, 12:52 p.m. by anton
Modified Jan. 10, 2017, 12:18 p.m.
Reviewers: diegocarloslima, Felix Dahlke
Base URL:
Comments: 13
This is Rietveld