Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(943)

Issue 29352640: Issue 4410 - Update runserver.spec for new pyinstaller versions (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 2 months ago by Wladimir Palant
Modified:
3 years, 2 months ago
Reviewers:
Vasily Kuznetsov
Base URL:
https://hg.adblockplus.org/cms/
Visibility:
Public.

Description

Issue 4410 - Update runserver.spec for new pyinstaller versions

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed unnecessary comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -18 lines) Patch
M runserver.spec View 1 1 chunk +1 line, -18 lines 0 comments Download

Messages

Total messages: 4
Wladimir Palant
3 years, 2 months ago (2016-09-12 10:44:03 UTC) #1
Vasily Kuznetsov
The now more compact pyinstaller spec looks good, it also builds and works. If I ...
3 years, 2 months ago (2016-09-13 16:29:37 UTC) #2
Wladimir Palant
https://codereview.adblockplus.org/29352640/diff/29352641/runserver.spec File runserver.spec (right): https://codereview.adblockplus.org/29352640/diff/29352641/runserver.spec#newcode3 runserver.spec:3: # Hidden imports are supposed to be analyzed recursively. ...
3 years, 2 months ago (2016-09-14 07:12:27 UTC) #3
Vasily Kuznetsov
3 years, 2 months ago (2016-09-14 10:19:43 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5