Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: sitescripts/formmail/web/formmail2.py

Issue 29352643: Issue 4377 - Add Configurable Form to Email Service (Closed)
Patch Set: adds test and fixed logic in handler Created Sept. 12, 2016, 1:58 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sitescripts/formmail/test/test_formmail2.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 # This file is part of the Adblock Plus web scripts,
2 # Copyright (C) 2006-2016 Eyeo GmbH
3 #
4 # Adblock Plus is free software: you can redistribute it and/or modify
5 # it under the terms of the GNU General Public License version 3 as
6 # published by the Free Software Foundation.
7 #
8 # Adblock Plus is distributed in the hope that it will be useful,
9 # but WITHOUT ANY WARRANTY; without even the implied warranty of
10 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11 # GNU General Public License for more details.
12 #
13 # You should have received a copy of the GNU General Public License
14 # along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
15
16 import re
17 import datetime
18 import collections
19 from urlparse import parse_qsl
20 from sitescripts.utils import get_config, sendMail, setupStderr
21 from sitescripts.web import registerUrlHandler
22
23
24 class BadRequestError(Exception):
25 pass
26
27
28 class ConfDict(collections.OrderedDict):
29 __slots__ = ('value',)
30
31
32 def get_config_items():
33 config = get_config()
34 default_keys = set(config.defaults())
35 for name, value in config.items('formmail2'):
36 if name not in default_keys:
37 yield name, value
38
39
40 def store_value(conf_dict, path, value):
41 head, tail = path[0], path[1:]
42 if head not in conf_dict:
43 conf_dict[head] = ConfDict()
44 if tail:
45 store_value(conf_dict[head], tail, value)
46 else:
47 conf_dict[head].value = value
48
49
50 def conf_parse(conf_items):
51 conf_dict = ConfDict()
52 for key, value in conf_items:
53 path = key.split('.')
54 store_value(conf_dict, path, value)
55 return conf_dict
56
57
58 def post_handler(handler):
59 def wrapped_handler(environ, start_response):
60 setupStderr(environ['wsgi.errors'])
61 response_headers = [('Content-Type', 'text/plain; charset=utf-8')]
62
63 try:
64 request_method = environ['REQUEST_METHOD'].upper()
65 url_encoded = 'application/x-www-form-urlencoded'
66 is_url_encoded = environ.get(
67 'CONTENT_TYPE', '').startswith(url_encoded)
68 if request_method != 'POST' or not is_url_encoded:
69 raise BadRequestError('Unsupported request method')
70 try:
71 request_body_length = int(environ['CONTENT_LENGTH'])
72 except:
73 raise BadRequestError(
74 'Invalid or missing Content-Length header')
75 request_body = environ['wsgi.input'].read(request_body_length)
76 params = {}
77 for key, value in parse_qsl(request_body):
78 params[key] = value.decode('utf-8').strip()
79
80 response = handler(params)
81 except BadRequestError as error:
82 start_response('400 Bad Request', response_headers)
83 return str(error)
84 start_response('200 OK', response_headers)
85 return response
86 return wrapped_handler
87
88
89 def make_error(field_name, spec, check_type, error_message):
90 if check_type in spec:
91 return spec[field_name].value
92 return error_message.format(field_name)
93
94
95 def make_handler(name, config):
96 try:
97 url = config['url'].value
98 except (KeyError, AttributeError):
99 raise Exception('No URL configured for form handler:' + name)
100 try:
101 template = config['template'].value
102 except (KeyError, AttributeError):
103 raise Exception('No template configured for form handler:' + name)
104 try:
105 fields = config['fields']
106 for field, spec in fields.items():
107 spec.value = set(spec.value.replace(' ', '').split(','))
108 except KeyError:
109 raise Exception('No fields configured for form handler:' + name)
110 if len(fields) == 0:
111 raise Exception('No fields configured for form handler:' + name)
112
113 @post_handler
114 def handler(params):
115 email_regex = r'^\w[\w.+!-]+@\w[\w.-]+\.[a-zA-Z]{2,6}$'
116 errors = []
117 for field, spec in fields.items():
118 if 'mandatory' in spec.value:
119 if field not in params.keys():
120 errors.append((make_error(field, spec, 'mandatory',
121 'No {} entered'.format(field))))
122 if 'email' in spec.value and field in params.keys():
123 if not re.search(email_regex, params[field]):
124 errors.append(make_error(field, spec, 'email',
125 'Invalid email'))
126 if errors:
127 raise BadRequestError('\n'.join(errors))
128 template_args = {
129 'time': datetime.datetime.now(),
130 'fields': {field: params.get(field, '') for field in fields}
131 }
132 sendMail(template, template_args)
133 return ''
134 return url, handler
135
136
137 conf_dict = conf_parse(get_config_items())
138 for name, config in conf_dict.items():
139 url, handler = make_handler(name, config)
140 registerUrlHandler(url, handler)
OLDNEW
« no previous file with comments | « sitescripts/formmail/test/test_formmail2.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld