Issue 4361 - Pass all parameters to initEvent

safari/ext/content.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 (function()
 {
   // the safari object is missing in frames created from javascript: URLs.
   // So we have to fallback to the safari object from the parent frame.
   if (!("safari" in window))
     window.safari = window.parent.safari;
 
 
   /* Intialization */
 
   var beforeLoadEvent = document.createEvent("Event");
-  beforeLoadEvent.initEvent("beforeload");
+  beforeLoadEvent.initEvent("beforeload", false, true);
 
   // Decide if we should use the new content blocker API or not. (Note when the
   // API is used Safari breaks the canLoad function, making it either throw an
   // exception or return true when used.)
   var usingContentBlockerAPI = true;
   try
   {
     if (safari.self.tab.canLoad(beforeLoadEvent,
                                 {category: "request",
                                  payload: {type: "prefs.get",
@@ skipping 106 matching lines @@
 
         // Safari doesn't dispatch the expected events for elements that have
         // been prevented from loading by having their "beforeload" event
         // cancelled. That is a "load" event for blocked frames, and an "error"
         // event for other blocked elements. We need to dispatch those events
         // manually here to avoid breaking element collapsing and pages that
         // rely on those events.
         setTimeout(function()
         {
           var evt = document.createEvent("Event");
-          evt.initEvent(eventName);
+          evt.initEvent(eventName, false, true);

[Sebastian Noack, 2016/09/16 12:42:52]

"load" and "error" event don't bubble. I think "beforeload" (above) doesn't
buuble either,but feel free to double check.

[Sebastian Noack, 2016/09/16 12:48:52]

Sorry, got it the wrong way around, the second argument (bubbles) is actually
correctly set to false. However, "load" and "error" events aren't cancelable, so
the third argument needs to be set to false too, here.

[kzar, 2016/09/16 13:00:43]

Done.

           event.target.dispatchEvent(evt);
         });
       }
     }, true);
   }
 
 
   /* Context menus */
 
   document.addEventListener("contextmenu", function(event)
@@ skipping 56 matching lines @@
   });
 
 
   /* Detecting extension reload/disable/uninstall (not supported on Safari) */
 
   ext.onExtensionUnloaded = {
     addListener: function() {},
     removeListener: function() {}
   };
 })();