Issue 4361 - Pass all parameters to initEvent

safari/include.youtube.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 (function() {
   if (document.domain != "www.youtube.com")
     return;
 
   var usingContentBlockerAPI = true;
   try
   {
-    var beforeLoadEvent = document.createEvent("Event");
-    beforeLoadEvent.initEvent("beforeload", false, true);

[Sebastian Noack, 2016/09/16 12:42:52]

Any reason, we don't simply use ext.backgroundPage.sendMessageSync() here?

[kzar, 2016/09/16 13:00:43]

I'm not sure, I can't remember to be honest.

[Sebastian Noack, 2016/09/16 13:29:03]

Then any reason you don't change it? That way this code would be redundant here.

[kzar, 2016/09/16 14:04:24]

Done.

-    if (safari.self.tab.canLoad(beforeLoadEvent,
-                                {category: "request",
-                                 payload: {type: "prefs.get",
-                                           key: "safariContentBlocker"}}) != true)
+    if (ext.backgroundPage.sendMessageSync({type: "prefs.get",
+                                            key: "safariContentBlocker"}) != true)
       usingContentBlockerAPI = false;
   }
   catch (e)
   {
   }
 
   if (usingContentBlockerAPI)
     return;
 
   if (ext.backgroundPage.sendMessageSync({type: "filters.isPageWhitelisted"}))
@@ skipping 125 matching lines @@
               config.args = rawConfig.args;
             }
           }
         });
 
         ytplayer.config = rawYtplayer.config;
       }
     });
   }, badArgumentsRegex.source);
 })();