safari/include.youtube.js - Issue 29353237: Issue 4361 - Pass all parameters to initEvent

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: safari/include.youtube.js

Issue 29353237: Issue 4361 - Pass all parameters to initEvent (Closed)

Patch Set: Use sendMessageSync Created Sept. 16, 2016, 2:02 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: safari/include.youtube.js

diff --git a/safari/include.youtube.js b/safari/include.youtube.js

index 33011d13f3050e5290b843e4f68c5ff9deeefd24..368b8ade40a729b13ed0d1d39c8393a34e3b5d57 100644

--- a/safari/include.youtube.js

+++ b/safari/include.youtube.js

@@ -22,12 +22,8 @@

var usingContentBlockerAPI = true;

try

{

- var beforeLoadEvent = document.createEvent("Event");

- beforeLoadEvent.initEvent("beforeload");

- if (safari.self.tab.canLoad(beforeLoadEvent,

- {category: "request",

- payload: {type: "prefs.get",

- key: "safariContentBlocker"}}) != true)

+ if (ext.backgroundPage.sendMessageSync({type: "prefs.get",

+ key: "safariContentBlocker"} != true))

Sebastian Noack 2016/09/16 14:06:43 Here is a typo. You are essentially always calling

kzar 2016/09/16 14:10:36 Whoops you are right, fixed.

usingContentBlockerAPI = false;

}

catch (e)

« no previous file with comments | « safari/ext/content.js ('k') | no next file » | no next file with comments »