Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(42)

Issue 29353434: Issue 4448 - Use websocket request type (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 1 month ago by kzar
Modified:
3 years, 1 month ago
Reviewers:
Wladimir Palant
CC:
Sebastian Noack
Visibility:
Public.

Description

Issue 4448 - Use websocket request type Depends on https://codereview.adblockplus.org/29353431/

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update dependency #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M dependencies View 1 1 chunk +1 line, -1 line 0 comments Download
M lib/requestBlocker.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
kzar
Patch Set 1 https://codereview.adblockplus.org/29353434/diff/29353435/dependencies File dependencies (right): https://codereview.adblockplus.org/29353434/diff/29353435/dependencies#newcode6 dependencies:6: adblockpluscore = adblockpluscore git:4387-websocket-type Obviously needs ...
3 years, 1 month ago (2016-09-20 09:53:52 UTC) #1
kzar
Patch Set 2 : Update dependency https://codereview.adblockplus.org/29353434/diff/29353435/dependencies File dependencies (right): https://codereview.adblockplus.org/29353434/diff/29353435/dependencies#newcode6 dependencies:6: adblockpluscore = adblockpluscore ...
3 years, 1 month ago (2016-09-20 10:57:55 UTC) #2
Wladimir Palant
3 years, 1 month ago (2016-09-20 11:42:35 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5