Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: lib/filterClasses.js

Issue 29354328: Noissue - Handle filters with only empty domains (Closed)
Patch Set: Created Sept. 20, 2016, 1:14 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/filterClasses.js
diff --git a/lib/filterClasses.js b/lib/filterClasses.js
index ddf9aff8ec82a7e1abdb8f81465bc53af9acb881..0206bbd1dce8a2fc48aa1024bf1850cd10f2d4ae 100644
--- a/lib/filterClasses.js
+++ b/lib/filterClasses.js
@@ -409,7 +409,8 @@ ActiveFilter.prototype = extend(Filter, {
domains[domain] = include;
}
- domains[""] = !hasIncludes;
+ if (domains)
+ domains[""] = !hasIncludes;
}
this.domainSource = null;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld