Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Delta Between Two Patch Sets: sitescripts/extensions/test/oracle/androidupdates.json
Issue
29354748
:
Fixes 4464 - Restore get_min_sdk_version() function from sitescripts.extensions.android module that… (Closed)
Base URL: https://hg.adblockplus.org/sitescripts
Left Patch Set:
Created Sept. 22, 2016, 4:03 p.m.
Right Patch Set: Mock plugin repositories instead of cloning them
Created Sept. 27, 2016, 9:44 a.m.
Left:
Base
Patch Set 1: None
Patch Set 2: Add a test
Patch Set 3: Mock plugin repositories instead of cloning them
Right:
Patch Set 1: None
Patch Set 2: Add a test
Patch Set 3: Mock plugin repositories instead of cloning them
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
sitescripts/extensions/bin/updateUpdateManifests.py
sitescripts/extensions/test/adblockplussafari.pem
sitescripts/extensions/test/data/AndroidManifest.xml
sitescripts/extensions/test/data/README.txt
sitescripts/extensions/test/data/downloads.list
sitescripts/extensions/test/data/metadata.gecko
sitescripts/extensions/test/data/metadata.safari
sitescripts/extensions/test/oracle/androidupdates.json
sitescripts/extensions/test/oracle/androidupdates.xml
sitescripts/extensions/test/oracle/ieupdate.json
sitescripts/extensions/test/oracle/update.rdf
sitescripts/extensions/test/oracle/updates.plist
sitescripts/extensions/test/sitescripts.ini.template
sitescripts/extensions/test/test_updateManifests.py
tox.ini
Right:
Side by side diff
|
Download
« no previous file with change/comment
|
« sitescripts/extensions/test/data/metadata.safari
('k') |
sitescripts/extensions/test/oracle/androidupdates.xml »
('j') |
no next file with change/comment »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
LEFT
RIGHT
(no file at all)
1
{
2
"adblockplusandroid": {
3
"url": "https://downloads.adblockplus.org/adblockplusandroid-1.3.apk?update" ,
4
"version": "1.3"
5
}
6
}
LEFT
RIGHT
« sitescripts/extensions/test/data/metadata.safari
('k') |
sitescripts/extensions/test/oracle/androidupdates.xml »
('j') |
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Toggle Comments
('s')
Edit Message
Issue 29354748: Fixes 4464 - Restore get_min_sdk_version() function from sitescripts.extensions.android module that… (Closed)
Created Sept. 22, 2016, 4:03 p.m. by Vasily Kuznetsov
Modified Oct. 4, 2016, 2:21 p.m.
Reviewers: Sebastian Noack, Wladimir Palant
Base URL: https://hg.adblockplus.org/sitescripts
Comments: 7
This is Rietveld