Issue 4465 - Move rsa module from adblockpluschrome

lib/rsa.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 /**
  * This is a specialized RSA library meant only to verify SHA1-based signatures.
  */
 
 let {BigInteger} = require("jsbn");
 let Rusha = require("rusha");
 
 let rusha = new Rusha();
-
-// Node.Js does not include atob, but we can make use of Buffer
-if (typeof atob == "undefined" && typeof Buffer != "undefined")
-  global.atob = data => new Buffer(data, "base64").toString("binary");

[kzar, 2016/09/23 13:48:45]

If I simply did `var atob = ...` here the tests broke in adblockpluschrome.
Don't ask me why, since `atob` should never be undefined there...

[Wladimir Palant, 2016/09/23 20:02:29]

atob() is defined on the window object, and Node doesn't have one (see
https://github.com/nodejs/node/issues/3462). Patching the module isn't the right
approach, you should rather add this method globally when running unit tests.

I've had the same problem with Easy Passwords, there I run nodeunit like this
now:

  let atob = str => new Buffer(str, "base64").toString("binary");
  let btoa = str => new Buffer(str, "binary").toString("base64");
  let navigator = {};

  let nodeunit = require("sandboxed-module").require("nodeunit", {
    globals: {atob, btoa, navigator}
  });
  nodeunit.reporters.default.run(files);

It seems that we need to do the same here in test_wrapper.js, requires
introducing sandboxed-module as development dependency. This dependency is well
worth it, it will also simplify rerouting requires significantly.

[kzar, 2016/09/25 12:46:47]

Good point. I already did a bunch of similar work[1] to get other tests running
for #4223, so if it's all the same will simply assign `GLOBAL.atob`.

(This makes me realise there are already far too many changes sitting in that
branch, I will upload a review today for what I have so far.)

[1] -
https://github.com/kzar/adblockpluscore/blob/4223-migrate-tests/test_wrapper.js

[Wladimir Palant, 2016/09/25 13:02:28]

sandboxed-module seems to be a cleaner solution to me but I won't insist.

 
 // Define ASN.1 templates for the data structures used
 function seq()
 {
   return {type: 0x30, children: Array.prototype.slice.call(arguments)};
 }
 function obj(id)
 {
   return {type: 0x06, content: id};
 }
@@ skipping 146 matching lines @@
     var expected = new BigInteger(rusha.digest(data), 16);
     return (sha1.compareTo(expected) == 0);
   }
   catch (e)
   {
     console.log("Invalid encrypted signature: " + e);
     return false;
   }
 }
 exports.verifySignature = verifySignature;