Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1320)

Issue 29354787: Issue 4442 - Cache class and ctors references in JNI_Load/UnLoad (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 10 months ago by anton
Modified:
2 years, 8 months ago
CC:
René Jeschke
Visibility:
Public.

Description

Issue 4442 - Cache class and ctors references in JNI_Load/UnLoad

Patch Set 1 #

Total comments: 11

Patch Set 2 : reverted to NewTuple #

Unified diffs Side-by-side diffs Delta from patch set Stats (+295 lines, -115 lines) Patch
M libadblockplus-android/jni/JniCallbacks.h View 1 6 chunks +4 lines, -13 lines 0 comments Download
M libadblockplus-android/jni/JniCallbacks.cpp View 2 chunks +21 lines, -4 lines 0 comments Download
A + libadblockplus-android/jni/JniFilter.h View 1 chunk +9 lines, -8 lines 0 comments Download
M libadblockplus-android/jni/JniFilter.cpp View 2 chunks +20 lines, -4 lines 0 comments Download
M libadblockplus-android/jni/JniFilterChangeCallback.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M libadblockplus-android/jni/JniJsValue.h View 1 chunk +2 lines, -0 lines 0 comments Download
M libadblockplus-android/jni/JniJsValue.cpp View 3 chunks +14 lines, -11 lines 0 comments Download
M libadblockplus-android/jni/JniLibrary.cpp View 3 chunks +17 lines, -0 lines 0 comments Download
A + libadblockplus-android/jni/JniLogSystem.h View 1 chunk +9 lines, -8 lines 0 comments Download
M libadblockplus-android/jni/JniLogSystem.cpp View 2 chunks +19 lines, -1 line 0 comments Download
A + libadblockplus-android/jni/JniNotification.h View 1 chunk +7 lines, -12 lines 0 comments Download
M libadblockplus-android/jni/JniNotification.cpp View 2 chunks +20 lines, -8 lines 0 comments Download
M libadblockplus-android/jni/JniShowNotificationCallback.cpp View 1 chunk +1 line, -2 lines 0 comments Download
A + libadblockplus-android/jni/JniWebRequest.h View 1 chunk +9 lines, -8 lines 0 comments Download
M libadblockplus-android/jni/JniWebRequest.cpp View 1 5 chunks +41 lines, -11 lines 0 comments Download
M libadblockplus-android/jni/Utils.h View 2 chunks +8 lines, -0 lines 0 comments Download
M libadblockplus-android/jni/Utils.cpp View 3 chunks +92 lines, -21 lines 0 comments Download

Messages

Total messages: 7
anton
https://codereview.adblockplus.org/29354787/diff/29354788/libadblockplus-android/jni/JniCallbacks.h File libadblockplus-android/jni/JniCallbacks.h (left): https://codereview.adblockplus.org/29354787/diff/29354788/libadblockplus-android/jni/JniCallbacks.h#oldcode107 libadblockplus-android/jni/JniCallbacks.h:107: jobject NewTuple(JNIEnv* env, const std::string& a, const std::string& b) ...
2 years, 10 months ago (2016-09-23 13:05:26 UTC) #1
anton
https://codereview.adblockplus.org/29354787/diff/29354788/libadblockplus-android/jni/JniFilter.h File libadblockplus-android/jni/JniFilter.h (left): https://codereview.adblockplus.org/29354787/diff/29354788/libadblockplus-android/jni/JniFilter.h#oldcode18 libadblockplus-android/jni/JniFilter.h:18: package org.adblockplus.libadblockplus; rietveld bug - the file did not ...
2 years, 10 months ago (2016-09-23 13:07:09 UTC) #2
diegocarloslima
https://codereview.adblockplus.org/29354787/diff/29354788/libadblockplus-android/jni/JniWebRequest.cpp File libadblockplus-android/jni/JniWebRequest.cpp (right): https://codereview.adblockplus.org/29354787/diff/29354788/libadblockplus-android/jni/JniWebRequest.cpp#newcode82 libadblockplus-android/jni/JniWebRequest.cpp:82: JniLocalReference<jobject> arrayList(*env, NewJniArrayList(*env)); On 2016/09/23 13:05:25, anton wrote: > ...
2 years, 8 months ago (2016-11-04 11:34:19 UTC) #3
diegocarloslima
On 2016/11/04 11:34:19, diegocarloslima wrote: > https://codereview.adblockplus.org/29354787/diff/29354788/libadblockplus-android/jni/JniWebRequest.cpp > File libadblockplus-android/jni/JniWebRequest.cpp (right): > > https://codereview.adblockplus.org/29354787/diff/29354788/libadblockplus-android/jni/JniWebRequest.cpp#newcode82 > ...
2 years, 8 months ago (2016-11-04 11:35:00 UTC) #4
Felix Dahlke
Looks pretty good to me, just one comment. https://codereview.adblockplus.org/29354787/diff/29354788/libadblockplus-android/jni/JniCallbacks.h File libadblockplus-android/jni/JniCallbacks.h (left): https://codereview.adblockplus.org/29354787/diff/29354788/libadblockplus-android/jni/JniCallbacks.h#oldcode107 libadblockplus-android/jni/JniCallbacks.h:107: jobject ...
2 years, 8 months ago (2016-11-18 10:42:23 UTC) #5
anton
https://codereview.adblockplus.org/29354787/diff/29354788/libadblockplus-android/jni/JniCallbacks.h File libadblockplus-android/jni/JniCallbacks.h (left): https://codereview.adblockplus.org/29354787/diff/29354788/libadblockplus-android/jni/JniCallbacks.h#oldcode107 libadblockplus-android/jni/JniCallbacks.h:107: jobject NewTuple(JNIEnv* env, const std::string& a, const std::string& b) ...
2 years, 8 months ago (2016-11-21 08:26:38 UTC) #6
Felix Dahlke
2 years, 8 months ago (2016-11-21 08:50:04 UTC) #7
LGTM!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5