Issue 4223 - Migrate some more of adblockplustests

test/cssRules.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 "use strict";
 
-let common = require("common");
+let {createSandbox} = require("./_common");
 
-let {CSSPropertyFilter} = require("filterClasses");
-let {CSSRules} = require("cssRules");
-let {ElemHide} = require("elemHide");
-let {Filter} = require("filterClasses");
+let CSSPropertyFilter = null;
+let CSSRules = null;
+let ElemHide = null;
+let Filter = null;
 
 exports.setUp = function(callback)
 {
-  common.prepareFilterComponents.call(this, true);

[Wladimir Palant, 2016/09/26 09:40:58]

Saving and restoring data is a hack that was necessary because these tests used
to run against live extension. IMHO here we only need a helper that will create
a new virtual environment:

  let requireSandboxed = require("common").createSandbox();

With createSandbox being something like:

  function createSandbox()
  {
    // Shared require cache for this sandbox
    let requires = {};

    let SandboxedModule = require("sandboxed-module");
    return moduleId =>
    {
      return SandboxedModule.require(moduleId, {
        requires,
        sourceTransformers: ...,
        globals: ...
      });
    };
  }

You can then create a new sandbox for each test and load the modules - no need
for any cleanup. If you want to be extra fancy, you could generalize
createSandbox() somewhat by passing in internal variables to be exported rather
than hardcoding them in source transformers.

[kzar, 2016/09/29 15:53:09]

Cool idea, it works great as you suggested except the requires Object. I found I
had to pass in a cache Object instead.

I also needed to make a change to sandboxed-module so that it was possible to
pass in a cache Object. I'm hoping he will accept my pull request... let's see.
https://github.com/felixge/node-sandboxed-module/pull/62

+  let sandboxedRequire = createSandbox();
+  (
+    {Filter, CSSPropertyFilter} = sandboxedRequire("../lib/filterClasses"),
+    {CSSRules} = sandboxedRequire("../lib/cssRules"),
+    {ElemHide} = sandboxedRequire("../lib/elemHide")
+  );
 
   callback();
 };
-
-exports.tearDown = function(callback)
-{
-  common.restoreFilterComponents.call(this);
-
-  callback();
-}
 
 exports.testDomainRestrictions = function(test)
 {
   function testSelectorMatches(description, filters, domain, expectedMatches)
   {
     for (let filter of filters)
     {
       filter = Filter.fromText(filter);
       if (filter instanceof CSSPropertyFilter)
         CSSRules.add(filter);
@@ skipping 79 matching lines @@
 
   CSSRules.clear();
   compareRules(
     "Return no filters after clearing",
     "www.example.com",
     []
   );
 
   test.done();
 };