Issue 4223 - Migrate some more of adblockplustests

test/cssRules.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 "use strict";
 
-let {createSandbox} = require("common");
-let sandboxedRequire = null;

[Wladimir Palant, 2016/09/30 09:37:53]

This doesn't need to be a global variable.

[kzar, 2016/10/03 13:46:14]

Done.

+let {createSandbox} = require("./_common");
 
 let CSSPropertyFilter = null;
 let CSSRules = null;
 let ElemHide = null;
 let Filter = null;
 
 exports.setUp = function(callback)
 {
   let sandboxedRequire = createSandbox();
-
-  ({Filter, CSSPropertyFilter} = sandboxedRequire("filterClasses"));
-  CSSRules = sandboxedRequire("cssRules").CSSRules;
-  ElemHide = sandboxedRequire("elemHide").ElemHide;

[Wladimir Palant, 2016/09/30 09:37:53]

How about:

  (
    {Filter, CSSPropertyFilter} = sandboxedRequire("filterClasses"),
    {CSSRules} = sandboxedRequire("cssRules"),
    {ElemHide} = sandboxedRequire("elemHide")
  );

[kzar, 2016/10/03 13:46:14]

Done.

+  (
+    {Filter, CSSPropertyFilter} = sandboxedRequire("../lib/filterClasses"),
+    {CSSRules} = sandboxedRequire("../lib/cssRules"),
+    {ElemHide} = sandboxedRequire("../lib/elemHide")
+  );
 
   callback();
 };
 
 exports.testDomainRestrictions = function(test)
 {
   function testSelectorMatches(description, filters, domain, expectedMatches)
   {
     for (let filter of filters)
     {
@@ skipping 82 matching lines @@
 
   CSSRules.clear();
   compareRules(
     "Return no filters after clearing",
     "www.example.com",
     []
   );
 
   test.done();
 };