Issue 4223 - Migrate some more of adblockplustests

test/domainRestrictions.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 "use strict";
 
-let {createSandbox} = require("common");
-let sandboxedRequire = createSandbox();
-
-let {Filter} = sandboxedRequire("filterClasses");

[Wladimir Palant, 2016/09/30 09:37:53]

Please put it in setUp function here as well - one sandbox per test, even if no
data modification is expected. In fact, filter.fromText() caches filters, you
wouldn't want that to mess with the tests. Same for all the other files with a
global sandbox, I'm not commenting there.

[kzar, 2016/10/03 13:46:14]

Done.

+let {createSandbox} = require("./_common");
+
+let Filter = null;
+
+exports.setUp = function(callback)
+{
+  let sandboxedRequire = createSandbox();
+  (
+    {Filter} = sandboxedRequire("../lib/filterClasses")
+  );
+
+  callback();
+};
 
 function testActive(test, text, domain, expectedActive, expectedOnlyDomain)
 {
   let filter = Filter.fromText(text);
   test.equal(filter.isActiveOnDomain(domain), expectedActive,
              text + " active on " + domain);
   test.equal(filter.isActiveOnlyOnDomain(domain), expectedOnlyDomain,
              text + " only active on " + domain);
 }
 
@@ skipping 162 matching lines @@
   testActive(test, "nnnnnnn.nnn#foo", null, false, false);
   testActive(test, "nnnnnnn.nnn#foo", "com", false, false);
   testActive(test, "nnnnnnn.nnn#foo", "example.com", false, false);
   testActive(test, "nnnnnnn.nnn#foo", "example.com.", false, false);
   testActive(test, "nnnnnnn.nnn#foo", "foo.example.com", false, false);
   testActive(test, "nnnnnnn.nnn#foo", "mple.com", false, false);
 
   test.done();
 };