Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: test/filterStorage.js

Issue 29354864: Issue 4223 - Migrate some more of adblockplustests (Closed)
Left Patch Set: Migrate filterStorage tests Created Sept. 29, 2016, 7:24 p.m.
Right Patch Set: Addressed final nit Created Oct. 4, 2016, 12:16 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « test/filterNotifier.js ('k') | test/matcher.js » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2016 Eyeo GmbH 3 * Copyright (C) 2006-2016 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU General Public License 14 * You should have received a copy of the GNU General Public License
15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
16 */ 16 */
17 17
18 "use strict"; 18 "use strict";
19 19
20 let {createSandbox} = require("common"); 20 let {createSandbox} = require("./_common");
21 let sandboxedRequire = null;
22 21
23 let Filter = null; 22 let Filter = null;
24 let FilterNotifier = null; 23 let FilterNotifier = null;
25 let FilterStorage = null; 24 let FilterStorage = null;
26 let Subscription = null; 25 let Subscription = null;
27 26
28 exports.setUp = function(callback) 27 exports.setUp = function(callback)
29 { 28 {
30 sandboxedRequire = createSandbox(); 29 let sandboxedRequire = createSandbox();
31 30
32 sandboxedRequire("filterListener"); 31 sandboxedRequire("../lib/filterListener");
33 32 (
34 Filter = sandboxedRequire("filterClasses").Filter; 33 {Filter} = sandboxedRequire("../lib/filterClasses"),
35 FilterNotifier = sandboxedRequire("filterNotifier").FilterNotifier; 34 {FilterNotifier} = sandboxedRequire("../lib/filterNotifier"),
36 FilterStorage = sandboxedRequire("filterStorage").FilterStorage; 35 {FilterStorage} = sandboxedRequire("../lib/filterStorage"),
37 Subscription = sandboxedRequire("subscriptionClasses").Subscription; 36 {Subscription} = sandboxedRequire("../lib/subscriptionClasses")
37 );
38 38
39 callback(); 39 callback();
40 }; 40 };
41 41
42 function compareSubscriptionList(test, testMessage, list) 42 function compareSubscriptionList(test, testMessage, list)
43 { 43 {
44 let result = FilterStorage.subscriptions.map(subscription => subscription.url) ; 44 let result = FilterStorage.subscriptions.map(subscription => subscription.url) ;
45 let expected = list.map(subscription => subscription.url); 45 let expected = list.map(subscription => subscription.url);
46 test.deepEqual(result, expected, testMessage); 46 test.deepEqual(result, expected, testMessage);
47 } 47 }
(...skipping 443 matching lines...) Expand 10 before | Expand all | Expand 10 after
491 compareFilterSubscriptions(test, "filter3 subscriptions after updating http:// test3/ filters", filter3, [subscription2]); 491 compareFilterSubscriptions(test, "filter3 subscriptions after updating http:// test3/ filters", filter3, [subscription2]);
492 492
493 FilterStorage.removeSubscription(subscription3); 493 FilterStorage.removeSubscription(subscription3);
494 494
495 compareFilterSubscriptions(test, "filter1 subscriptions after removing http:// test3/", filter1, []); 495 compareFilterSubscriptions(test, "filter1 subscriptions after removing http:// test3/", filter1, []);
496 compareFilterSubscriptions(test, "filter2 subscriptions after removing http:// test3/", filter2, [subscription2]); 496 compareFilterSubscriptions(test, "filter2 subscriptions after removing http:// test3/", filter2, [subscription2]);
497 compareFilterSubscriptions(test, "filter3 subscriptions after removing http:// test3/", filter3, [subscription2]); 497 compareFilterSubscriptions(test, "filter3 subscriptions after removing http:// test3/", filter3, [subscription2]);
498 498
499 test.done(); 499 test.done();
500 }; 500 };
LEFTRIGHT

Powered by Google App Engine
This is Rietveld