Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: lib/crawler.js

Issue 29355247: Noissue - fix according to coding style (Closed)
Patch Set: Created Sept. 29, 2016, 8:46 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * This Source Code is subject to the terms of the Mozilla Public License 2 * This Source Code is subject to the terms of the Mozilla Public License
3 * version 2.0 (the "License"). You can obtain a copy of the License at 3 * version 2.0 (the "License"). You can obtain a copy of the License at
4 * http://mozilla.org/MPL/2.0/. 4 * http://mozilla.org/MPL/2.0/.
5 */ 5 */
6 6
7 'use strict';
8
7 /** 9 /**
8 * @module crawler 10 * @module crawler
9 */ 11 */
10 12
11 Cu.import("resource://gre/modules/Services.jsm"); 13 const {XPCOMUtils} = Cu.import("resource://gre/modules/XPCOMUtils.jsm", {});
12 Cu.import("resource://gre/modules/Task.jsm"); 14 const {Task} = Cu.import("resource://gre/modules/Task.jsm");
Wladimir Palant 2016/09/29 10:36:10 Please add the second parameter, otherwise it stil
sergei 2016/09/29 12:46:16 Done in https://codereview.adblockplus.org/2935527
13 Cu.import("resource://gre/modules/Promise.jsm");
14 15
15 function abprequire(module) 16 function abprequire(module)
16 { 17 {
17 let result = {}; 18 let result = {};
18 result.wrappedJSObject = result; 19 result.wrappedJSObject = result;
19 Services.obs.notifyObservers(result, "adblockplus-require", module); 20 Services.obs.notifyObservers(result, "adblockplus-require", module);
20 return result.exports; 21 return result.exports;
21 } 22 }
22 23
23 let {RequestNotifier} = abprequire("requestNotifier"); 24 let {RequestNotifier} = abprequire("requestNotifier");
(...skipping 370 matching lines...) Expand 10 before | Expand all | Expand 10 after
394 395
395 function reportException(e) 396 function reportException(e)
396 { 397 {
397 let stack = ""; 398 let stack = "";
398 if (e && typeof e == "object" && "stack" in e) 399 if (e && typeof e == "object" && "stack" in e)
399 stack = e.stack + "\n"; 400 stack = e.stack + "\n";
400 401
401 Cu.reportError(e); 402 Cu.reportError(e);
402 dump(e + "\n" + stack + "\n"); 403 dump(e + "\n" + stack + "\n");
403 } 404 }
OLDNEW

Powered by Google App Engine
This is Rietveld