Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: lib/commandLine.js

Issue 29355271: Noissue - Don't import JavaScript modules into the global scope (includes removing unused module). (Closed)
Patch Set: address comments Created Sept. 29, 2016, 8:56 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | lib/crawler.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/commandLine.js
diff --git a/lib/commandLine.js b/lib/commandLine.js
index efa9b4b216ab90137af078e8e37e606f9e7ea104..d4b759fa0e126fa1f23d76a9b53455594bab2f29 100644
--- a/lib/commandLine.js
+++ b/lib/commandLine.js
@@ -10,8 +10,7 @@
* @module commandLine
*/
-Cu.import("resource://gre/modules/Services.jsm");
-Cu.import("resource://gre/modules/XPCOMUtils.jsm");
+const {XPCOMUtils} = Cu.import("resource://gre/modules/XPCOMUtils.jsm", {});
let CommandLineHandler =
{
« no previous file with comments | « no previous file | lib/crawler.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld