Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(142)

Issue 29355386: Issue 4463 - Content blocker unavailable error message (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 1 month ago by diegocarloslima
Modified:
3 years, 1 month ago
Reviewers:
anton, Felix Dahlke
Visibility:
Public.

Description

Issue 4463 - Content blocker unavailable error message

Patch Set 1 #

Total comments: 3

Patch Set 2 : Reverting ABP version to hardcoded String #

Patch Set 3 : Adjusting indentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -49 lines) Patch
M res/values/sysstrings.xml View 1 chunk +2 lines, -0 lines 0 comments Download
M src/org/adblockplus/sbrowser/contentblocker/ContentBlockerContentProvider.java View 3 chunks +4 lines, -41 lines 0 comments Download
M src/org/adblockplus/sbrowser/contentblocker/engine/Engine.java View 1 2 6 chunks +87 lines, -4 lines 0 comments Download
M src/org/adblockplus/sbrowser/contentblocker/engine/Subscriptions.java View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 5
diegocarloslima
3 years, 1 month ago (2016-09-30 02:50:32 UTC) #1
anton
On 2016/09/30 02:50:32, diegocarloslima wrote: LGTM
3 years, 1 month ago (2016-09-30 06:21:12 UTC) #2
Felix Dahlke
Looks good, just two comments. https://codereview.adblockplus.org/29355386/diff/29355387/src/org/adblockplus/sbrowser/contentblocker/engine/Engine.java File src/org/adblockplus/sbrowser/contentblocker/engine/Engine.java (right): https://codereview.adblockplus.org/29355386/diff/29355387/src/org/adblockplus/sbrowser/contentblocker/engine/Engine.java#newcode58 src/org/adblockplus/sbrowser/contentblocker/engine/Engine.java:58: public static final String ...
3 years, 1 month ago (2016-09-30 07:11:41 UTC) #3
diegocarloslima
https://codereview.adblockplus.org/29355386/diff/29355387/src/org/adblockplus/sbrowser/contentblocker/engine/Engine.java File src/org/adblockplus/sbrowser/contentblocker/engine/Engine.java (right): https://codereview.adblockplus.org/29355386/diff/29355387/src/org/adblockplus/sbrowser/contentblocker/engine/Engine.java#newcode58 src/org/adblockplus/sbrowser/contentblocker/engine/Engine.java:58: public static final String ABP_VERSION = "2.0"; On 2016/09/30 ...
3 years, 1 month ago (2016-09-30 14:06:38 UTC) #4
Felix Dahlke
3 years, 1 month ago (2016-10-12 04:56:37 UTC) #5
Sorry, missed your response for some reason - LGTM!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5