Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(124)

Issue 29355396: Issue 4380 - Add Mock Crowdin API and Sync Test (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 4 months ago by Jon Sonesen
Modified:
3 years, 3 months ago
Visibility:
Public.

Description

Issue 4380 - Add Mock Crowdin API and Sync Test Repository: hg.adblockplus.org/cms

Patch Set 1 #

Total comments: 4

Patch Set 2 : Add basic assertion for sync test #

Total comments: 22

Patch Set 3 : #

Total comments: 2

Patch Set 4 : better assertions and expected request data added #

Total comments: 2

Patch Set 5 : formatting fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+219 lines, -19 lines) Patch
A tests/conftest.py View 1 chunk +18 lines, -0 lines 0 comments Download
A tests/crowdin_mock_api.py View 1 2 3 4 1 chunk +120 lines, -0 lines 0 comments Download
A tests/expected_output/translate View 1 chunk +1 line, -0 lines 0 comments Download
M tests/test_page_outputs.py View 2 chunks +10 lines, -17 lines 0 comments Download
A tests/test_site/locales/de/translate.json View 1 chunk +6 lines, -0 lines 0 comments Download
A tests/test_site/pages/translate.md View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M tests/test_site/settings.ini View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
A tests/test_translations.py View 1 2 3 4 1 chunk +53 lines, -0 lines 0 comments Download
M tox.ini View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 21
Jon Sonesen
3 years, 4 months ago (2016-09-30 07:20:38 UTC) #1
Jon Sonesen
https://codereview.adblockplus.org/29355396/diff/29355397/tests/test_page_outputs.py File tests/test_page_outputs.py (left): https://codereview.adblockplus.org/29355396/diff/29355397/tests/test_page_outputs.py#oldcode50 tests/test_page_outputs.py:50: p = subprocess.Popen(['python', 'runserver.py', temp_site]) There is a problem ...
3 years, 4 months ago (2016-09-30 07:28:01 UTC) #2
Jon Sonesen
here are some comments https://codereview.adblockplus.org/29355396/diff/29355397/tests/test_translations.py File tests/test_translations.py (right): https://codereview.adblockplus.org/29355396/diff/29355397/tests/test_translations.py#newcode16 tests/test_translations.py:16: shutil.make_archive(zip_name, 'zip', input_dir) the archive ...
3 years, 4 months ago (2016-09-30 07:33:56 UTC) #3
Jon Sonesen
https://codereview.adblockplus.org/29355396/diff/29355397/tests/mock_api.py File tests/mock_api.py (right): https://codereview.adblockplus.org/29355396/diff/29355397/tests/mock_api.py#newcode1 tests/mock_api.py:1: from flask import Flask, send_from_directory, jsonify I used this ...
3 years, 4 months ago (2016-09-30 07:35:12 UTC) #4
Vasily Kuznetsov
I just summarised our talk about asserting the CMS behaviour below. I think we don't ...
3 years, 4 months ago (2016-09-30 14:38:31 UTC) #5
Jon Sonesen
https://codereview.adblockplus.org/29355396/diff/29355828/tests/mock_api.py File tests/mock_api.py (right): https://codereview.adblockplus.org/29355396/diff/29355828/tests/mock_api.py#newcode4 tests/mock_api.py:4: app.request_data = {} This is my preliminary solution to ...
3 years, 4 months ago (2016-10-05 03:54:50 UTC) #6
Sebastian Noack
https://codereview.adblockplus.org/29355396/diff/29355828/tests/mock_api.py File tests/mock_api.py (right): https://codereview.adblockplus.org/29355396/diff/29355828/tests/mock_api.py#newcode1 tests/mock_api.py:1: from flask import Flask, send_from_directory, jsonify, request I wonder ...
3 years, 4 months ago (2016-10-05 12:06:16 UTC) #7
Jon Sonesen
https://codereview.adblockplus.org/29355396/diff/29355828/tests/mock_api.py File tests/mock_api.py (right): https://codereview.adblockplus.org/29355396/diff/29355828/tests/mock_api.py#newcode1 tests/mock_api.py:1: from flask import Flask, send_from_directory, jsonify, request On 2016/10/05 ...
3 years, 4 months ago (2016-10-05 14:38:14 UTC) #8
Jon Sonesen
3 years, 4 months ago (2016-10-05 14:40:47 UTC) #9
Vasily Kuznetsov
https://codereview.adblockplus.org/29355396/diff/29355828/tests/mock_api.py File tests/mock_api.py (right): https://codereview.adblockplus.org/29355396/diff/29355828/tests/mock_api.py#newcode4 tests/mock_api.py:4: app.request_data = {} On 2016/10/05 03:54:49, Jon Sonesen wrote: ...
3 years, 4 months ago (2016-10-05 14:44:42 UTC) #10
Sebastian Noack
https://codereview.adblockplus.org/29355396/diff/29355828/tests/mock_api.py File tests/mock_api.py (right): https://codereview.adblockplus.org/29355396/diff/29355828/tests/mock_api.py#newcode1 tests/mock_api.py:1: from flask import Flask, send_from_directory, jsonify, request On 2016/10/05 ...
3 years, 4 months ago (2016-10-05 16:36:44 UTC) #11
Vasily Kuznetsov
https://codereview.adblockplus.org/29355396/diff/29355828/tests/test_translations.py File tests/test_translations.py (right): https://codereview.adblockplus.org/29355396/diff/29355828/tests/test_translations.py#newcode25 tests/test_translations.py:25: urllib3_intercept.install() On 2016/10/05 16:36:44, Sebastian Noack wrote: > On ...
3 years, 4 months ago (2016-10-06 09:39:00 UTC) #12
Sebastian Noack
https://codereview.adblockplus.org/29355396/diff/29355828/tests/test_translations.py File tests/test_translations.py (right): https://codereview.adblockplus.org/29355396/diff/29355828/tests/test_translations.py#newcode25 tests/test_translations.py:25: urllib3_intercept.install() On 2016/10/06 09:38:59, Vasily Kuznetsov wrote: > On ...
3 years, 4 months ago (2016-10-06 10:25:26 UTC) #13
Jon Sonesen
https://codereview.adblockplus.org/29355396/diff/29355828/tests/mock_api.py File tests/mock_api.py (right): https://codereview.adblockplus.org/29355396/diff/29355828/tests/mock_api.py#newcode1 tests/mock_api.py:1: from flask import Flask, send_from_directory, jsonify, request On 2016/10/05 ...
3 years, 4 months ago (2016-10-08 02:21:41 UTC) #14
Vasily Kuznetsov
Looks good. Now it would be good to add some more meaningful assertions to that ...
3 years, 4 months ago (2016-10-11 17:33:25 UTC) #15
Jon Sonesen
On 2016/10/11 17:33:25, Vasily Kuznetsov wrote: > Looks good. Now it would be good to ...
3 years, 4 months ago (2016-10-19 02:15:05 UTC) #16
Vasily Kuznetsov
A couple of minor formatting suggestions (and I'm not super strong on those ones) but ...
3 years, 3 months ago (2016-10-20 17:17:40 UTC) #17
Jon Sonesen
Here are the formatting fixes
3 years, 3 months ago (2016-10-25 08:16:06 UTC) #18
Jon Sonesen
Here are the formatting fixes
3 years, 3 months ago (2016-10-25 08:16:08 UTC) #19
Vasily Kuznetsov
On 2016/10/25 08:16:08, Jon Sonesen wrote: > Here are the formatting fixes LGTM
3 years, 3 months ago (2016-10-25 09:53:38 UTC) #20
Sebastian Noack
3 years, 3 months ago (2016-10-25 10:05:57 UTC) #21
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5