Issue 4380 - Add Mock Crowdin API and Sync Test

tests/test_translations.py

 import os
 import shutil
 import pytest
-import mock_api
 from wsgi_intercept import urllib3_intercept
 from wsgi_intercept import add_wsgi_intercept
 from wsgi_intercept import remove_wsgi_intercept
 
+from crowdin_mock_api import app
 from cms.bin import translate
+
+
+@pytest.fixture(scope='module')
+def expect_requests():
+    return [
+        ('info?key=test_key&json=1', ''),
+        ('supported-languages?key=test_key&json=1', ''),
+        ('add-file?key=test_key&json=1', 'translate.json'),
+        ('upload-translation?key=test_key&json=1', 'test_sample'),
+        ('delete-file?key=test_key&json=1', 'translate.json'),
+        ('delete-file?key=test_key&json=1', 'translate.json'),
+        ('delete-directory?key=test_key&json=1', 'de'),
+        ('delete-directory?key=test_key&json=1', 'en'),
+        ('export?key=test_key&json=1', ''),
+        ('download/all.zip?key=test_key', ''),
+    ]
 
 
 @pytest.fixture(scope='module')
 def make_crowdin_zip(temp_site):
     zip_name = os.path.join('tests', 'all')
     input_dir = os.path.join(temp_site, 'locales')
     shutil.make_archive(zip_name, 'zip', input_dir)

[Jon Sonesen, 2016/09/30 07:33:56]

the archive is not made in the temp site because the api has know way of knowing
that path, also not sure about assigning variables here for those paths

     yield None
     os.remove(zip_name + '.zip')
 
 
 @pytest.fixture()
 def make_intercept(scope='module'):
     host = 'api.crowdin.com'
     port = 443
     urllib3_intercept.install()
-    add_wsgi_intercept(host, port, lambda: mock_api.app.wsgi_app)
+    add_wsgi_intercept(host, port, lambda: app.wsgi_app)
     yield None
     remove_wsgi_intercept()
 
 
-def test_sync(temp_site, make_intercept, make_crowdin_zip):
+def test_sync(temp_site, make_intercept, make_crowdin_zip, expect_requests):
     translate.crowdin_sync(temp_site, 'test_key')

[Vasily Kuznetsov, 2016/09/30 14:38:31]

As we discussed, we should add assertions to this call. Basically apart from
making sure it doesn't crash, we also need to make sure it did what we expected
it to do.

Some ideas about what and how we could check (basically notes from our quick
brainstorm session):
- That the CMS got the translations from our API mock and put them where they
should be. Just look at the filesystem and check that the right files are there.
- That the CMS called the API mock as we expect with expected parameters. We
could add an attribute to `mock_api.app` that is a list and make sure our
handlers add the relevant logging data to this list. Then we can return this
list from the fixture as its value so inside the test we can look at what's
there after the call and make sure it's right.

+    for (url, data), (expect_url, expect_data) in zip(
+                                                      app.request_log,
+                                                      expect_requests):
+        assert expect_url in url
+        assert expect_data in data