Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1221)

Issue 29356018: Issue 4450 - Prevent ElemHide filters with empty domains (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 9 months ago by kzar
Modified:
2 years, 9 months ago
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Issue 4450 - Prevent ElemHide filters with empty domains

Patch Set 1 #

Total comments: 6

Patch Set 2 : Addressed feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -59 lines) Patch
M lib/elemHide.js View 7 chunks +19 lines, -43 lines 0 comments Download
M lib/filterClasses.js View 1 1 chunk +6 lines, -0 lines 0 comments Download
M test/elemHide.js View 1 chunk +0 lines, -16 lines 0 comments Download
M test/filterClasses.js View 1 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 4
kzar
Patch Set 1 So far I only check that ElemHide filters don't have empty domains. ...
2 years, 9 months ago (2016-10-05 14:30:44 UTC) #1
Wladimir Palant
> I realised > that `Filter.optionsRegExp` doesn't match option strings like > "$domains=foo.com,," so to ...
2 years, 9 months ago (2016-10-06 08:06:15 UTC) #2
kzar
Patch Set 2 : Addressed feedback > Or maybe keep in mind that RegExpFilter has ...
2 years, 9 months ago (2016-10-06 08:53:56 UTC) #3
Wladimir Palant
2 years, 9 months ago (2016-10-06 09:46:29 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5