Issue 524 - Stop using @-moz-document

lib/child/elemHide.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 192 matching lines @@
 
   isPending: () => false,
   cancel: notImplemented,
   suspend: notImplemented,
   resume: notImplemented,
 
   QueryInterface: XPCOMUtils.generateQI([Ci.nsIChannel, Ci.nsIRequest])
 };
 
 /**
- * Channel returning CSS data for the global stylesheet.

[kzar, 2016/10/06 12:10:46]

Nit: I guess this comment should be updated now it's also for domain specific
stylesheets.

[Wladimir Palant, 2016/10/06 12:27:28]

Done.

+ * Channel returning CSS data for the global as well as site-specific stylesheet.
  * @constructor
  */
 function StyleDataChannel(uri, loadInfo, domain)
 {
   BaseChannel.call(this, uri, loadInfo);
   this._domain = domain;
 }
 StyleDataChannel.prototype = {
   __proto__: BaseChannel.prototype,
   contentType: "text/css",
   _domain: null,
 
   _getResponse: function()
   {
     function escapeChar(match)
     {
       return "\\" + match.charCodeAt(0).toString(16) + " ";
     }
 
     // Would be great to avoid sync messaging here but nsIStyleSheetService
     // insists on opening channels synchronously.
     let [selectors, keys] = (this._domain ?
         port.emitSync("getSelectorsForDomain", this._domain) :

[kzar, 2016/10/06 12:10:46]

Dumb question but how does getSelectorsForDomain and getUncondtionalSelectors
resolve to ElemHide.getSelectorsForDomain and ElemHide.getUncondtionalSelectors?
I can't see where you've required them.

[Wladimir Palant, 2016/10/06 12:27:28]

This is the content process - we cannot require ElemHide here (at least not
without duplicating all the data which we don't want). This is a message sent to
the parent process, elemHideFF.js will produce the proper response then.

[kzar, 2016/10/06 13:02:32]

Ah I see.

         port.emitSync("getUnconditionalSelectors"));
 
     let cssPrefix = "{-moz-binding: url(about:abp-elemhide?hit";
     let cssSuffix = "#dummy) !important;}\n";
     let result = [];
 
     for (let i = 0; i < selectors.length; i++)
     {
       let selector = selectors[i];
       let key = keys[i];
@@ skipping 22 matching lines @@
   _getResponse: function()
   {
     let window = Utils.getRequestWindow(this);
     port.emitWithResponse("registerElemHideHit", {
       key: this.key,
       frames: getFrames(window),
       isPrivate: isPrivate(window)
     }).then(hit =>
     {
       if (hit)
         RequestNotifier.addNodeData(window.document, window.top, hit);

[kzar, 2016/10/06 13:02:32]

(Doesn't storing all the details returned by registerElemHideHit for each hidden
element add quite a bit of overhead? On the other hand I guess it's kind of
useful to know when element hiding filters have matched.)

[Wladimir Palant, 2016/10/06 13:08:48]

That's how the list of blockable items works - it needs to show everything that
affected the display of the current page. Not having element hiding in there
would leave out an important piece of the data.

The other feature using this data is the issue reporter - it also needs to know
which filters matched on the current page.

     });
     return "<bindings xmlns='http://www.mozilla.org/xbl'/>";
   }
 };
 
 let observer = {
   QueryInterface: XPCOMUtils.generateQI([
     Ci.nsIObserver, Ci.nsISupportsWeakReference
   ]),
 
@@ skipping 92 matching lines @@
       else if (filter)
       {
         RequestNotifier.addNodeData(window.document, window.top, {
           contentType, docDomain, thirdParty, location, filter, filterType
         });
       }
     });
   }
 };
 observer.init();