Issue 4499 - Consider $generichide exceptions when applying element hiding rules

lib/elemHideFF.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 31 matching lines @@
 });
 
 port.on("getUnconditionalSelectors", () =>
 {
   return [
     ElemHide.getUnconditionalSelectors(),
     ElemHide.getUnconditionalFilterKeys()
   ];
 });
 
-port.on("getSelectorsForDomain", domain =>
+port.on("getSelectorsForDomain", ([domain, specificOnly]) =>
 {
-  return ElemHide.getSelectorsForDomain(domain, ElemHide.NO_UNCONDITIONAL,
-    true);
+  let type = specificOnly ? ElemHide.SPECIFIC_ONLY : ElemHide.NO_UNCONDITIONAL;
+  return ElemHide.getSelectorsForDomain(domain, type, true);
 });
 
 port.on("elemhideEnabled", ({frames, isPrivate}) =>
 {
   if (!Prefs.enabled)
     return {enabled: false};
 
   let hit = Policy.isFrameWhitelisted(frames, true);
   if (hit)
   {
     let [frameIndex, contentType, docDomain, thirdParty, location, filter] = hit;
-    if (contentType != "GENERICHIDE")
-    {
-      if (!isPrivate)
-        FilterStorage.increaseHitCount(filter);
-      return {
-        enabled: false,
-        contentType, docDomain, thirdParty, location,
-        filter: filter.text, filterType: filter.type
-      };
-    }
+    if (!isPrivate)
+      FilterStorage.increaseHitCount(filter);
+    return {
+      enabled: contentType == "GENERICHIDE",
+      contentType, docDomain, thirdParty, location,
+      filter: filter.text, filterType: filter.type
+    };
   }
 
   return {enabled: true};
 });
 
 port.on("registerElemHideHit", ({key, frames, isPrivate}) =>
 {
   let filter = ElemHide.getFilterByKey(key);
   if (!filter)
     return null;
@@ skipping 13 matching lines @@
 
   return {
     contentType: "ELEMHIDE",
     docDomain,
     thirdParty: false,
     location: filter.text.replace(/^.*?#/, '#'),
     filter: filter.text,
     filterType: filter.type
   };
 });